Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2452183002: Fix separator positioning in app menu dropdown in RTL. (Closed)

Created:
4 years, 1 month ago by Peter Kasting
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG=655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Review-Url: https://codereview.chromium.org/2448903002 Cr-Commit-Position: refs/heads/master@{#427439} (cherry picked from commit 200957be2c524036da93b36b69360f8d4ed83c81) Committed: https://chromium.googlesource.com/chromium/src/+/5e91bed12e40a4568953d09679727c5c9857ca93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Kasting
4 years, 1 month ago (2016-10-26 21:32:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e91bed12e40a4568953d09679727c5c9857ca93.

Powered by Google App Engine
This is Rietveld 408576698