Issue 2452183002: Fix separator positioning in app menu dropdown in RTL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2452183002: Fix separator positioning in app menu dropdown in RTL. (Closed)

Created:
4 years, 1 month ago by Peter Kasting

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG=655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Review-Url: https://codereview.chromium.org/2448903002 Cr-Commit-Position: refs/heads/master@{#427439} (cherry picked from commit 200957be2c524036da93b36b69360f8d4ed83c81) Committed: https://chromium.googlesource.com/chromium/src/+/5e91bed12e40a4568953d09679727c5c9857ca93

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/toolbar/app_menu.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Peter Kasting

4 years, 1 month ago (2016-10-26 21:32:23 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5e91bed12e40a4568953d09679727c5c9857ca93.