Fix separator positioning in app menu dropdown in RTL.

Fix separator positioning in app menu dropdown in RTL.

See bug for details.

BUG=655555
TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version.

Committed: https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81
Cr-Commit-Position: refs/heads/master@{#427439}

[Peter Kasting, 2016-10-25 07:06:07]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[Peter Kasting, 2016-10-25 07:06:07]

I reversed the logic of the old code when converting this in
https://codereview.chromium.org/2261593002/diff/20001/chrome/browser/ui/views...
.  The key is in the comment on this code: "...and the button _isn't_ mirroring
itself."

(I don't know, BTW, which buttons do and don't mirror themselves.  I wonder if
there really is a mixture of ones that do and don't.  If not this could probably
be simplified further.  I don't intend to investigate.)

[sky, 2016-10-25 16:49:18]

LGTM

https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/app_menu.cc (right):

https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/app_menu.cc:166: canvas, view->width(),
!view->flip_canvas_on_paint_for_rtl_ui());
Please add a comment here as it isn't obvious why the ! is needed.

[Peter Kasting, 2016-10-25 17:51:00]

https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/app_menu.cc (right):

https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/app_menu.cc:166: canvas, view->width(),
!view->flip_canvas_on_paint_for_rtl_ui());
On 2016/10/25 16:49:18, sky wrote:
> Please add a comment here as it isn't obvious why the ! is needed.

Updated comments for clarity.

[Peter Kasting, 2016-10-25 17:51:05]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-10-25 17:51:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2448903002/#ps20001
(title: "Update comment")

[commit-bot: I haz the power, 2016-10-25 17:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 19:31:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 19:35:57]

Description was changed from

==========
Fix separator positioning in app menu dropdown in RTL.

See bug for details.

BUG=655555
TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu
area looks like the mirror image of the LTR version.
==========

to

==========
Fix separator positioning in app menu dropdown in RTL.

See bug for details.

BUG=655555
TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu
area looks like the mirror image of the LTR version.

Committed: https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81
Cr-Commit-Position: refs/heads/master@{#427439}
==========

[commit-bot: I haz the power, 2016-10-25 19:35:57]

Patchset 2 (id:??) landed as
https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81
Cr-Commit-Position: refs/heads/master@{#427439}