Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2448903002: Fix separator positioning in app menu dropdown in RTL. (Closed)

Created:
4 years, 1 month ago by Peter Kasting
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix separator positioning in app menu dropdown in RTL. See bug for details. BUG=655555 TEST=Launch Chrome with --lang=he, click app button, and make sure zoom menu area looks like the mirror image of the LTR version. Committed: https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81 Cr-Commit-Position: refs/heads/master@{#427439}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Peter Kasting
I reversed the logic of the old code when converting this in https://codereview.chromium.org/2261593002/diff/20001/chrome/browser/ui/views/toolbar/app_menu.cc . The ...
4 years, 1 month ago (2016-10-25 07:06:07 UTC) #2
sky
LGTM https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc File chrome/browser/ui/views/toolbar/app_menu.cc (right): https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc#newcode166 chrome/browser/ui/views/toolbar/app_menu.cc:166: canvas, view->width(), !view->flip_canvas_on_paint_for_rtl_ui()); Please add a comment here ...
4 years, 1 month ago (2016-10-25 16:49:18 UTC) #3
Peter Kasting
https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc File chrome/browser/ui/views/toolbar/app_menu.cc (right): https://codereview.chromium.org/2448903002/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc#newcode166 chrome/browser/ui/views/toolbar/app_menu.cc:166: canvas, view->width(), !view->flip_canvas_on_paint_for_rtl_ui()); On 2016/10/25 16:49:18, sky wrote: > ...
4 years, 1 month ago (2016-10-25 17:51:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2448903002/20001
4 years, 1 month ago (2016-10-25 17:51:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 19:31:23 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 19:35:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/200957be2c524036da93b36b69360f8d4ed83c81
Cr-Commit-Position: refs/heads/master@{#427439}

Powered by Google App Engine
This is Rietveld 408576698