Rename AccountId method GetGaiaIdKey() to GetAccountIdKey().

Rename AccountId method GetGaiaIdKey() to GetAccountIdKey().

THis CL renames storage-key generation method to better reflect its purpose.

BUG=656992
Committed: https://crrev.com/3da3a44c5916df101a9420fa2a9a168c4af2ccee
Cr-Commit-Position: refs/heads/master@{#428293}

[Alexander Alekseev, 2016-10-26 14:23:43]

alemate@chromium.org changed reviewers:
+ dkrahn@chromium.org, rogerta@chromium.org

[Alexander Alekseev, 2016-10-26 14:23:43]

I postponed updates to several local confusing function names (like Get/Set
GaiaIdMigrationStatus() ) for future changes. This is only about
AccountId::GEtGaiaIdKey().

Please review:

rogerta@:
  components/signin/core/account_id/*

dkrahn@:
  chromeos/cryptohome/*

[Alexander Alekseev, 2016-10-26 14:23:49]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 14:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:11:18]

Dry run: This issue passed the CQ dry run.

[Roger Tawa OOO till Jul 10th, 2016-10-26 18:32:20]

lgtm, see comment below for a pretty important relationship between account id,
gaia id, and email.

https://codereview.chromium.org/2452053002/diff/1/components/signin/core/acco...
File components/signin/core/account_id/account_id.h (right):

https://codereview.chromium.org/2452053002/diff/1/components/signin/core/acco...
components/signin/core/account_id/account_id.h:38: // This returns prefixed
GaiaId string to be used as a storage key.
This comment is misleading.  Users of AccountId should make no assumptions about
the format of the account id, gaia id, and email address.  They should treat the
three as non-decomposable and non-comparable strings.

[Alexander Alekseev, 2016-10-27 05:02:22]

https://codereview.chromium.org/2452053002/diff/1/components/signin/core/acco...
File components/signin/core/account_id/account_id.h (right):

https://codereview.chromium.org/2452053002/diff/1/components/signin/core/acco...
components/signin/core/account_id/account_id.h:38: // This returns prefixed
GaiaId string to be used as a storage key.
On 2016/10/26 18:32:20, Roger Tawa wrote:
> This comment is misleading.  Users of AccountId should make no assumptions
about
> the format of the account id, gaia id, and email address.  They should treat
the
> three as non-decomposable and non-comparable strings.

I was about to delay updating of comments to the future changes, but you're
right. Earlier is always better. ;)

Done.

[Alexander Alekseev, 2016-10-27 22:42:17]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 22:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:04:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:04:47]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Alekseev, 2016-10-28 03:18:27]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 03:18:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Darren Krahn, 2016-10-28 04:31:15]

lgtm

[commit-bot: I haz the power, 2016-10-28 04:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:40:48]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-10-28 05:44:46]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-10-28 05:44:46]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/2452053002/#ps40001
(title: "Updated comments")

[commit-bot: I haz the power, 2016-10-28 05:44:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 05:49:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 05:51:32]

Description was changed from

==========
Rename AccountId method GetGaiaIdKey() to GetAccountIdKey().

THis CL renames storage-key generation method to better reflect its purpose.

BUG=656992
==========

to

==========
Rename AccountId method GetGaiaIdKey() to GetAccountIdKey().

THis CL renames storage-key generation method to better reflect its purpose.

BUG=656992

Committed: https://crrev.com/3da3a44c5916df101a9420fa2a9a168c4af2ccee
Cr-Commit-Position: refs/heads/master@{#428293}
==========

[commit-bot: I haz the power, 2016-10-28 05:51:33]

Patchset 3 (id:??) landed as
https://crrev.com/3da3a44c5916df101a9420fa2a9a168c4af2ccee
Cr-Commit-Position: refs/heads/master@{#428293}