Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: components/signin/core/account_id/account_id.h

Issue 2452053002: Rename AccountId method GetGaiaIdKey() to GetAccountIdKey(). (Closed)
Patch Set: Updated comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/login/auth/cryptohome_authenticator.cc ('k') | components/signin/core/account_id/account_id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/account_id/account_id.h
diff --git a/components/signin/core/account_id/account_id.h b/components/signin/core/account_id/account_id.h
index fe567d4ff621ec6fce81cdc22b005b095f33ceff..7cba697805da512d5819523cd8998bffad5b3de3 100644
--- a/components/signin/core/account_id/account_id.h
+++ b/components/signin/core/account_id/account_id.h
@@ -33,10 +33,14 @@ class AccountId {
const std::string& GetAccountType() const;
const std::string& GetGaiaId() const;
+ // Users of AccountId should make no assumptions on the format of email.
+ // I.e. it cannot be used as account identifier, because it is (in general)
+ // non-comparable.
const std::string& GetUserEmail() const;
- // This returns prefixed GaiaId string to be used as a storage key.
- const std::string GetGaiaIdKey() const;
+ // This returns prefixed some string that can be used as a storage key.
+ // You should make no assumptions on the format of this string.
+ const std::string GetAccountIdKey() const;
void SetGaiaId(const std::string& gaia_id);
void SetUserEmail(const std::string& email);
« no previous file with comments | « chromeos/login/auth/cryptohome_authenticator.cc ('k') | components/signin/core/account_id/account_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698