Use ChannelMojo between the remoting network and desktop processes.

Use ChannelMojo between the remoting network and desktop processes.

This also removes uses of IPC::AttachmentBroker from //remoting/host.
With the IPC channels that are used to send handles using ChannelMojo,
AttachmentBroker is no longer necessary.

BUG=604282
Committed: https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c
Cr-Commit-Position: refs/heads/master@{#428929}

[Sam McNally, 2016-10-26 00:14:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:51:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Sam McNally, 2016-10-26 03:46:32]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 03:46:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 03:59:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 03:59:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-10-27 03:42:54]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 03:43:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 05:08:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 05:08:27]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Sam McNally, 2016-10-27 06:55:37]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 06:55:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 07:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 07:52:26]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-10-27 23:08:16]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-10-27 23:08:20]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-10-27 23:08:20]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2016-10-28 00:15:47]

Description was changed from

==========
Use ChannelMojo between the remoting network and desktop processes.

BUG=604282
==========

to

==========
Use ChannelMojo between the remoting network and desktop processes.

This also removes uses of IPC::AttachmentBroker from //remoting/host.
With the IPC channels that are used to send handles using ChannelMojo,
AttachmentBroker is no longer necessary.

BUG=604282
==========

[Sam McNally, 2016-10-28 00:44:46]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-10-28 02:41:42]

Patchset #1 (id:80001) has been deleted

[Sam McNally, 2016-10-28 02:46:52]

sammc@chromium.org changed reviewers:
+ joedow@chromium.org

[Sam McNally, 2016-10-28 03:32:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 03:32:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:27:34]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-10-31 16:41:03]

lgtm with some comment changes.

chromoting_messages.* has a different set of owners so you'll need to add
someone with the ability to review/lgtm that file as well.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/chromoti...
File remoting/host/chromoting_messages.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/chromoti...
remoting/host/chromoting_messages.h:57: // a desktop integration process.
|desktop_process| is the handle of the desktop
Remove |desktop_process| comment since the parameter was removed.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
File remoting/host/daemon_process.cc (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
remoting/host/daemon_process.cc:185: // TODO(sergeyu): On OSX,
mojo::edk::SetMachPortProvider() should be called
Since you are updating the contents of the TODO, it might be more appropriate to
replace sergeyu with sammc.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
File remoting/host/daemon_process.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
remoting/host/daemon_process.h:79: // |desktop_process| is a handle of the
desktop integration process.
Remove desktop_process comment.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/desktop_...
File remoting/host/desktop_session_connector.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/desktop_...
remoting/host/desktop_session_connector.h:44: // a desktop integration process.
|desktop_process_handle| specifies the
Remove |desktop_process_handle| comment

[Sam McNally, 2016-10-31 22:34:27]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org

[Sam McNally, 2016-10-31 22:34:28]

+dcheng for remoting/host/chromoting_messages.h

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/chromoti...
File remoting/host/chromoting_messages.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/chromoti...
remoting/host/chromoting_messages.h:57: // a desktop integration process.
|desktop_process| is the handle of the desktop
On 2016/10/31 16:41:03, joedow wrote:
> Remove |desktop_process| comment since the parameter was removed.

Done.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
File remoting/host/daemon_process.cc (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
remoting/host/daemon_process.cc:185: // TODO(sergeyu): On OSX,
mojo::edk::SetMachPortProvider() should be called
On 2016/10/31 16:41:03, joedow wrote:
> Since you are updating the contents of the TODO, it might be more appropriate
to
> replace sergeyu with sammc.  

Done.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
File remoting/host/daemon_process.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/daemon_p...
remoting/host/daemon_process.h:79: // |desktop_process| is a handle of the
desktop integration process.
On 2016/10/31 16:41:03, joedow wrote:
> Remove desktop_process comment.

Done.

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/desktop_...
File remoting/host/desktop_session_connector.h (right):

https://codereview.chromium.org/2451953002/diff/100001/remoting/host/desktop_...
remoting/host/desktop_session_connector.h:44: // a desktop integration process.
|desktop_process_handle| specifies the
On 2016/10/31 16:41:03, joedow wrote:
> Remove |desktop_process_handle| comment

Done.

[dcheng, 2016-11-01 02:36:10]

ipc lgtm

[Sam McNally, 2016-11-01 02:49:21]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-11-01 02:49:22]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/2451953002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-11-01 02:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 03:49:27]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-11-01 03:51:22]

Description was changed from

==========
Use ChannelMojo between the remoting network and desktop processes.

This also removes uses of IPC::AttachmentBroker from //remoting/host.
With the IPC channels that are used to send handles using ChannelMojo,
AttachmentBroker is no longer necessary.

BUG=604282
==========

to

==========
Use ChannelMojo between the remoting network and desktop processes.

This also removes uses of IPC::AttachmentBroker from //remoting/host.
With the IPC channels that are used to send handles using ChannelMojo,
AttachmentBroker is no longer necessary.

BUG=604282

Committed: https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c
Cr-Commit-Position: refs/heads/master@{#428929}
==========

[commit-bot: I haz the power, 2016-11-01 03:51:32]

Patchset 2 (id:??) landed as
https://crrev.com/e66272fae18796359ea4e0deba41a1c9770ce27c
Cr-Commit-Position: refs/heads/master@{#428929}