Pass the desktop session ID to the remoting network process.

Pass the desktop session ID to the remoting network process.

Currently, the network process uses ProcessIdToSessionId to determine
the desktop session ID of the remoting session. This can fail due to a
lack of permissions, which can cause remote security key
connections to be incorrectly rejected. With this CL, the daemon
process, which already knows the session ID, sends it to the network
process when a session is attached.

BUG=604282
Committed: https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13
Cr-Commit-Position: refs/heads/master@{#429416}

[Sam McNally, 2016-10-31 23:00:44]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 23:01:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 00:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:20:53]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-11-01 06:00:06]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-11-01 06:37:07]

sammc@chromium.org changed reviewers:
+ joedow@chromium.org

[Sam McNally, 2016-11-01 06:37:07]

On my testing setup I think this was causing problems both before and after my
mojo-related changes. I don't know whether this was caused by a regression or by
some quirk of my testing setup though. In any case, this approach should be at
least as reliable as the old approach.

[Sam McNally, 2016-11-01 23:36:52]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 23:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 00:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 00:36:07]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-11-02 15:59:51]

lgtm

[Sam McNally, 2016-11-02 20:29:44]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org

[Sam McNally, 2016-11-02 20:29:45]

+dcheng for remoting/host/chromoting_messages.h

[dcheng, 2016-11-02 21:50:35]

The IPC change LGTM.

It might be good to have a followup bug to figure out why this is failing in the
network process though: I would expect ProcessIdToSessionId to consistently
succeed or consistently fail. Why does the network process sometimes lack
permissions?

[Sam McNally, 2016-11-02 22:05:04]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:05:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:13:51]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-02 22:17:07]

Description was changed from

==========
Pass the desktop session ID to the remoting network process.

Currently, the network process uses ProcessIdToSessionId to determine
the desktop session ID of the remoting session. This can fail due to a
lack of permissions, which can cause remote security key
connections to be incorrectly rejected. With this CL, the daemon
process, which already knows the session ID, sends it to the network
process when a session is attached.

BUG=604282
==========

to

==========
Pass the desktop session ID to the remoting network process.

Currently, the network process uses ProcessIdToSessionId to determine
the desktop session ID of the remoting session. This can fail due to a
lack of permissions, which can cause remote security key
connections to be incorrectly rejected. With this CL, the daemon
process, which already knows the session ID, sends it to the network
process when a session is attached.

BUG=604282

Committed: https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13
Cr-Commit-Position: refs/heads/master@{#429416}
==========

[commit-bot: I haz the power, 2016-11-02 22:17:08]

Patchset 2 (id:??) landed as
https://crrev.com/f9cd299a223bda159c2982a1957160f1baea7b13
Cr-Commit-Position: refs/heads/master@{#429416}