Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2451933003: base: Erase unused FOR_EACH_OBSERVER macro. (Closed)

Created:
4 years, 1 month ago by loyso (OOO)
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Erase unused FOR_EACH_OBSERVER macro. We use the range based for loop from now. BUG=655021 Committed: https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438 Cr-Commit-Position: refs/heads/master@{#427623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -9 lines 0 comments Download
M base/android/java/src/org/chromium/base/ObserverList.java View 1 chunk +1 line, -1 line 0 comments Download
M base/observer_list.h View 1 chunk +0 lines, -7 lines 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
loyso (OOO)
jochen@, PRESUBMIT.py please
4 years, 1 month ago (2016-10-25 23:10:26 UTC) #4
dcheng
Nice! base LGTM
4 years, 1 month ago (2016-10-26 00:25:27 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-26 07:01:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451933003/1
4 years, 1 month ago (2016-10-26 07:08:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 07:13:27 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 07:15:16 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/802c2138162919a3602f4eb20feb3e4020b81438
Cr-Commit-Position: refs/heads/master@{#427623}

Powered by Google App Engine
This is Rietveld 408576698