PRESUBMIT.py - Issue 2451933003: base: Erase unused FOR_EACH_OBSERVER macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2451933003: base: Erase unused FOR_EACH_OBSERVER macro. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 1cf31b9c8602784497be3deed13334ef562554b2..1953d76667af217edb6dd291265cbec8dcc49ed8 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -308,15 +308,6 @@ _BANNED_CPP_FUNCTIONS = (

(),

(

- r'FOR_EACH_OBSERVER(',

- (

- 'Use range-based for loops to iterate through base::ObserverList, e.g.',

- ' for (auto& observer : observers) { observer.Observe(); }',

- ),

- True,

- (),

- ),

- (

r'STLDeleteContainerPointers', # http://crbug.com/555865

(

'This call is obsolete with C++ 11; create a container with owning',

« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/ObserverList.java » ('j') | no next file with comments »