[DONT COMMIT] Inspector: Change V8InspectorClient to support Worklets [2]

Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopOnPause() like other methods. WorkerThreadDebugger needs this to
forward a quit operation to an appropriate worker context. See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559

[nhiroki, 2016-10-27 05:48:27]

Description was changed from

==========
(WIP) Inspector: Change V8InspectorClient to support Workletst commit

BUG=
==========

to

==========
(WIP) Inspector: Change V8InspectorClient to support Worklets

BUG=
==========

[nhiroki, 2016-11-01 01:18:31]

Patchset #2 (id:20001) has been deleted

[nhiroki, 2016-11-02 08:09:06]

Description was changed from

==========
(WIP) Inspector: Change V8InspectorClient to support Worklets

BUG=
==========

to

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopPnPause() like other methods. This is necessary for
WorkerThreadDebugger to forward an operation to an appropriate worker context.
See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

[nhiroki, 2016-11-02 08:09:17]

Description was changed from

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopPnPause() like other methods. This is necessary for
WorkerThreadDebugger to forward an operation to an appropriate worker context.
See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

to

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopPnPause() like other methods. This is necessary for
WorkerThreadDebugger to forward an operation to an appropriate worker context.
See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

[nhiroki, 2016-11-02 08:09:38]

Patchset #2 (id:40001) has been deleted

[nhiroki, 2016-11-02 08:09:44]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-11-02 08:12:53]

Description was changed from

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopPnPause() like other methods. This is necessary for
WorkerThreadDebugger to forward an operation to an appropriate worker context.
See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

to

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopOnPause() like other methods. WorkerThreadDebugger needs this to
forward a quit operation to an appropriate worker context. See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

[nhiroki, 2016-11-02 08:24:20]

Description was changed from

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopOnPause() like other methods. WorkerThreadDebugger needs this to
forward a quit operation to an appropriate worker context. See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

to

==========
Inspector: Change V8InspectorClient to support Worklets [2]

After this change, V8InspectClient passes contextGroupId via
quitMessageLoopOnPause() like other methods. WorkerThreadDebugger needs this to
forward a quit operation to an appropriate worker context. See [3] for details.

[1] Chromium: https://codereview.chromium.org/2469233002/
[2] V8: THIS PATCH
[3] Chromium: https://codereview.chromium.org/2456733002/

BUG=646559
==========

[dgozman, 2016-11-02 17:13:46]

dgozman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-11-02 17:13:47]

https://codereview.chromium.org/2451893005/diff/60001/include/v8-inspector.h
File include/v8-inspector.h (right):

https://codereview.chromium.org/2451893005/diff/60001/include/v8-inspector.h#...
include/v8-inspector.h:166: virtual void quitMessageLoopOnPause(int
contextGroupId) {}
V8Inspector guarantees that quitMessageLoopOnPause is not reentrant and thus it
is always called for the same context group as runMessageLoopOnPause.

Embedder can just store pausedContextGroupId and use it in
quitMessageLoopOnPause.

Since everything is run on the same isolate, all the groups will be essentially
paused at the same time anyway. We only use this group id to resume from
embedder when the paused frame is removed.

[nhiroki, 2016-11-04 11:30:30]

https://codereview.chromium.org/2451893005/diff/60001/include/v8-inspector.h
File include/v8-inspector.h (right):

https://codereview.chromium.org/2451893005/diff/60001/include/v8-inspector.h#...
include/v8-inspector.h:166: virtual void quitMessageLoopOnPause(int
contextGroupId) {}
On 2016/11/02 17:13:47, dgozman wrote:
> V8Inspector guarantees that quitMessageLoopOnPause is not reentrant and thus
it
> is always called for the same context group as runMessageLoopOnPause.
> 
> Embedder can just store pausedContextGroupId and use it in
> quitMessageLoopOnPause.
> 
> Since everything is run on the same isolate, all the groups will be
essentially
> paused at the same time anyway. We only use this group id to resume from
> embedder when the paused frame is removed.

Thank you for the clarification. I'll address this in the 3rd CL :)