[DONT COMMIT] Inspector: Change V8InspectorClient to support Worklets [2]

include/v8-inspector.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_V8_INSPECTOR_H_
 #define V8_V8_INSPECTOR_H_
 
 #include <stdint.h>
 #include <cctype>
 
@@ skipping 145 matching lines @@
   virtual void releaseObjectGroup(const StringView&) = 0;
 };
 
 enum class V8ConsoleAPIType { kClear, kDebug, kLog, kInfo, kWarning, kError };
 
 class V8_EXPORT V8InspectorClient {
  public:
   virtual ~V8InspectorClient() {}
 
   virtual void runMessageLoopOnPause(int contextGroupId) {}
-  virtual void quitMessageLoopOnPause() {}
+  virtual void quitMessageLoopOnPause(int contextGroupId) {}

[dgozman, 2016/11/02 17:13:47]

V8Inspector guarantees that quitMessageLoopOnPause is not reentrant and thus it
is always called for the same context group as runMessageLoopOnPause.

Embedder can just store pausedContextGroupId and use it in
quitMessageLoopOnPause.

Since everything is run on the same isolate, all the groups will be essentially
paused at the same time anyway. We only use this group id to resume from
embedder when the paused frame is removed.

[nhiroki, 2016/11/04 11:30:30]

Thank you for the clarification. I'll address this in the 3rd CL :)

   virtual void runIfWaitingForDebugger(int contextGroupId) {}
 
   virtual void muteMetrics(int contextGroupId) {}
   virtual void unmuteMetrics(int contextGroupId) {}
 
   virtual void beginUserGesture() {}
   virtual void endUserGesture() {}
 
   virtual std::unique_ptr<StringBuffer> valueSubtype(v8::Local<v8::Value>) {
     return nullptr;
@@ skipping 81 matching lines @@
 
   // API methods.
   virtual std::unique_ptr<V8StackTrace> createStackTrace(
       v8::Local<v8::StackTrace>) = 0;
   virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0;
 };
 
 }  // namespace v8_inspector
 
 #endif  // V8_V8_INSPECTOR_H_