Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: src/isolate.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index cafe546191bba737b06692b79d23808ec40feee5..61785fab89400e540d81cd9d88944318fa1f0bcd 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -633,7 +633,7 @@ class CaptureStackTraceHelper {
if (!line_key_.is_null()) {
Script::PositionInfo info;
bool valid_pos =
- script->GetPositionInfo(position, &info, Script::WITH_OFFSET);
+ Script::GetPositionInfo(script, position, &info, Script::WITH_OFFSET);
if (!column_key_.is_null() && valid_pos) {
JSObject::AddProperty(stack_frame, column_key_,
@@ -2266,7 +2266,6 @@ void Isolate::Deinit() {
delete interpreter_;
interpreter_ = NULL;
-
delete compiler_dispatcher_tracer_;
compiler_dispatcher_tracer_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698