Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/isolate.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 626
627 Handle<JSObject> NewStackFrameObject(Handle<JSFunction> fun, int position, 627 Handle<JSObject> NewStackFrameObject(Handle<JSFunction> fun, int position,
628 bool is_constructor) { 628 bool is_constructor) {
629 Handle<JSObject> stack_frame = 629 Handle<JSObject> stack_frame =
630 factory()->NewJSObject(isolate_->object_function()); 630 factory()->NewJSObject(isolate_->object_function());
631 Handle<Script> script(Script::cast(fun->shared()->script()), isolate_); 631 Handle<Script> script(Script::cast(fun->shared()->script()), isolate_);
632 632
633 if (!line_key_.is_null()) { 633 if (!line_key_.is_null()) {
634 Script::PositionInfo info; 634 Script::PositionInfo info;
635 bool valid_pos = 635 bool valid_pos =
636 script->GetPositionInfo(position, &info, Script::WITH_OFFSET); 636 Script::GetPositionInfo(script, position, &info, Script::WITH_OFFSET);
637 637
638 if (!column_key_.is_null() && valid_pos) { 638 if (!column_key_.is_null() && valid_pos) {
639 JSObject::AddProperty(stack_frame, column_key_, 639 JSObject::AddProperty(stack_frame, column_key_,
640 handle(Smi::FromInt(info.column + 1), isolate_), 640 handle(Smi::FromInt(info.column + 1), isolate_),
641 NONE); 641 NONE);
642 } 642 }
643 JSObject::AddProperty(stack_frame, line_key_, 643 JSObject::AddProperty(stack_frame, line_key_,
644 handle(Smi::FromInt(info.line + 1), isolate_), 644 handle(Smi::FromInt(info.line + 1), isolate_),
645 NONE); 645 NONE);
646 } 646 }
(...skipping 1612 matching lines...) Expand 10 before | Expand all | Expand 10 after
2259 heap_profiler_ = NULL; 2259 heap_profiler_ = NULL;
2260 2260
2261 cancelable_task_manager()->CancelAndWait(); 2261 cancelable_task_manager()->CancelAndWait();
2262 2262
2263 heap_.TearDown(); 2263 heap_.TearDown();
2264 logger_->TearDown(); 2264 logger_->TearDown();
2265 2265
2266 delete interpreter_; 2266 delete interpreter_;
2267 interpreter_ = NULL; 2267 interpreter_ = NULL;
2268 2268
2269
2270 delete compiler_dispatcher_tracer_; 2269 delete compiler_dispatcher_tracer_;
2271 compiler_dispatcher_tracer_ = nullptr; 2270 compiler_dispatcher_tracer_ = nullptr;
2272 2271
2273 delete cpu_profiler_; 2272 delete cpu_profiler_;
2274 cpu_profiler_ = NULL; 2273 cpu_profiler_ = NULL;
2275 2274
2276 code_event_dispatcher_.reset(); 2275 code_event_dispatcher_.reset();
2277 2276
2278 delete root_index_map_; 2277 delete root_index_map_;
2279 root_index_map_ = NULL; 2278 root_index_map_ = NULL;
(...skipping 1206 matching lines...) Expand 10 before | Expand all | Expand 10 after
3486 // Then check whether this scope intercepts. 3485 // Then check whether this scope intercepts.
3487 if ((flag & intercept_mask_)) { 3486 if ((flag & intercept_mask_)) {
3488 intercepted_flags_ |= flag; 3487 intercepted_flags_ |= flag;
3489 return true; 3488 return true;
3490 } 3489 }
3491 return false; 3490 return false;
3492 } 3491 }
3493 3492
3494 } // namespace internal 3493 } // namespace internal
3495 } // namespace v8 3494 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698