Uniform and precise source positions for inlining

src/compiler/bytecode-graph-builder.h

Index: src/compiler/bytecode-graph-builder.h
diff --git a/src/compiler/bytecode-graph-builder.h b/src/compiler/bytecode-graph-builder.h
index d2feb93a201defcdfbf7b6c67e15d374ad6f25f4..951f3bbcc3178369f219ec15244dfb161070a797 100644
--- a/src/compiler/bytecode-graph-builder.h
+++ b/src/compiler/bytecode-graph-builder.h
@@ -9,7 +9,6 @@
 #include "src/compiler/bytecode-loop-analysis.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/liveness-analyzer.h"
-#include "src/compiler/source-position.h"
 #include "src/compiler/state-values-utils.h"
 #include "src/compiler/type-hint-analyzer.h"
 #include "src/interpreter/bytecode-array-iterator.h"
@@ -20,17 +19,22 @@
 namespace v8 {
 namespace internal {
 
+// Forward declarations.

[vogelheim, 2016/11/07 17:53:26]

nitpick: Drop comment. It's indeed a forward declaration, but the reader will
realize this without the comment.

Reference:
https://google.github.io/styleguide/cppguide.html#Implementation_Comments,
subsection "Don'ts": "Do not state the obvious. In particular, don't literally
describe what code does [...]"

 class CompilationInfo;
 
 namespace compiler {
 
+// Forward declarations.
+class SourcePositionTable;
+
 // The BytecodeGraphBuilder produces a high-level IR graph based on
 // interpreter bytecodes.
 class BytecodeGraphBuilder {
  public:
   BytecodeGraphBuilder(Zone* local_zone, CompilationInfo* info,
                        JSGraph* jsgraph, float invocation_frequency,
-                       SourcePositionTable* source_positions);
+                       SourcePositionTable* source_positions,
+                       int inlining_id = SourcePosition::kNotInlined);
 
   // Creates a graph by visiting bytecodes.
   bool CreateGraph(bool stack_check = true);
@@ -317,6 +321,9 @@ class BytecodeGraphBuilder {
   // The Turbofan source position table, to be populated.
   SourcePositionTable* source_positions_;
 
+  SourcePosition const start_position_;
+  int const inlining_id_;

[alph, 2016/11/07 22:38:39]

Isn't inlining_id already a part of start_position_ ?

+
   // Update [source_positions_]'s current position to that of the bytecode at
   // [offset], if any.
   void UpdateCurrentSourcePosition(SourcePositionTableIterator* it, int offset);