Uniform and precise source positions for inlining

src/compiler/bytecode-graph-builder.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_
 #define V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_
 
 #include "src/compiler/bytecode-branch-analysis.h"
 #include "src/compiler/bytecode-loop-analysis.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/liveness-analyzer.h"
-#include "src/compiler/source-position.h"
 #include "src/compiler/state-values-utils.h"
 #include "src/compiler/type-hint-analyzer.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-flags.h"
 #include "src/interpreter/bytecodes.h"
 #include "src/source-position-table.h"
 
 namespace v8 {
 namespace internal {
 
+// Forward declarations.

[vogelheim, 2016/11/07 17:53:26]

nitpick: Drop comment. It's indeed a forward declaration, but the reader will
realize this without the comment.

Reference:
https://google.github.io/styleguide/cppguide.html#Implementation_Comments,
subsection "Don'ts": "Do not state the obvious. In particular, don't literally
describe what code does [...]"

 class CompilationInfo;
 
 namespace compiler {
 
+// Forward declarations.
+class SourcePositionTable;
+
 // The BytecodeGraphBuilder produces a high-level IR graph based on
 // interpreter bytecodes.
 class BytecodeGraphBuilder {
  public:
   BytecodeGraphBuilder(Zone* local_zone, CompilationInfo* info,
                        JSGraph* jsgraph, float invocation_frequency,
-                       SourcePositionTable* source_positions);
+                       SourcePositionTable* source_positions,
+                       int inlining_id = SourcePosition::kNotInlined);
 
   // Creates a graph by visiting bytecodes.
   bool CreateGraph(bool stack_check = true);
 
  private:
   class Environment;
 
   void VisitBytecodes(bool stack_check);
 
   // Get or create the node that represents the outer function closure.
@@ skipping 266 matching lines @@
   bool const is_liveness_analysis_enabled_;
 
   StateValuesCache state_values_cache_;
 
   // Analyzer of register liveness.
   LivenessAnalyzer liveness_analyzer_;
 
   // The Turbofan source position table, to be populated.
   SourcePositionTable* source_positions_;
 
+  SourcePosition const start_position_;
+  int const inlining_id_;

[alph, 2016/11/07 22:38:39]

Isn't inlining_id already a part of start_position_ ?

+
   // Update [source_positions_]'s current position to that of the bytecode at
   // [offset], if any.
   void UpdateCurrentSourcePosition(SourcePositionTableIterator* it, int offset);
 
   static int const kBinaryOperationHintIndex = 1;
   static int const kCountOperationHintIndex = 0;
   static int const kBinaryOperationSmiHintIndex = 2;
 
   DISALLOW_COPY_AND_ASSIGN(BytecodeGraphBuilder);
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_BYTECODE_GRAPH_BUILDER_H_