Require username and credential for turn/turns

third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html

Index: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
diff --git a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
index 490fe95f509b8052bbc0b0d4b693473ef7788946..ec9296e72793274ba8acdd8575704795d15ab9fe 100644
--- a/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
+++ b/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection.html
@@ -15,10 +15,10 @@ shouldThrow("new webkitRTCPeerConnection('');");
 
 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[]});");
 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'stun:foo.com'}]});");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'}]});");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', credential:'x'},{url:'stun:bar.com'}]});");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'x', credential:'x'}]});");
+shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{url:'turn:foo.com', username:'x', credential:'x'},{url:'stun:bar.com'}]});");
 shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:'stun:foo.com'}]});");
-shouldNotThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]});");
+shouldThrow("new webkitRTCPeerConnection({iceServers:[{urls:['stun:foo.com', 'turn:foo.com']}]});");

[hta - Chromium, 2016/10/25 13:47:54]

This loses test coverage that we succeed if we have two URLs in the urls array.
Can you add a test case for that (with username and credentials, of course)?

[foolip, 2016/11/08 16:31:48]

Right you are, I've restored the non-throwing test.

 
 shouldNotThrow("new webkitRTCPeerConnection({fooServers:[]});");
 shouldThrow("new webkitRTCPeerConnection({iceServers:true});");