chrome/browser/chromeos/extensions/file_manager/private_api_util.cc - Issue 2451713002: Propagate the read_only_hardware flag of volumes to js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

Issue 2451713002: Propagate the read_only_hardware flag of volumes to js. (Closed)

Patch Set: Rename the field name to is_read_only_removable_device, as it's only valid for removable devices. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc ('k') | chrome/browser/chromeos/file_manager/volume_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

index a63b9553efc4db0f5e17c71b376542286ef61c96..ee08fae00bf8d35169f78b296f17ef28095d1b40 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

@@ -196,6 +196,8 @@ void VolumeToVolumeMetadata(

break;

case SOURCE_DEVICE:

volume_metadata->source = file_manager_private::SOURCE_DEVICE;

+ volume_metadata->is_read_only_removable_device = volume

+ .is_read_only_removable_device();

break;

case SOURCE_NETWORK:

volume_metadata->source =