Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc

Issue 2451713002: Propagate the read_only_hardware flag of volumes to js. (Closed)
Patch Set: Rename the field name to is_read_only_removable_device, as it's only valid for removable devices. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc b/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
index 32fe7cd7775f8333572997f26df81a2195d99740..8e157427aa237c376ed0e6641a9de0b19850de39 100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
@@ -46,7 +46,7 @@ struct TestDiskInfo {
chromeos::DeviceType device_type;
uint64_t size_in_bytes;
bool is_parent;
- bool is_read_only;
+ bool is_read_only_hardware;
bool has_media;
bool on_boot_device;
bool on_removable_device;
@@ -109,7 +109,7 @@ TestDiskInfo kTestDisks[] = {
{
"system_path3",
"file_path3",
- false,
+ true, // write_disabled_by_policy
"device_label3",
"drive_label3",
"89ab",
@@ -121,7 +121,7 @@ TestDiskInfo kTestDisks[] = {
chromeos::DEVICE_TYPE_OPTICAL_DISC,
0,
true,
- false,
+ false, // is_hardware_read_only
false,
true,
false,
@@ -289,7 +289,7 @@ class FileManagerPrivateApiTest : public ExtensionApiTest {
kTestDisks[disk_info_index].device_type,
kTestDisks[disk_info_index].size_in_bytes,
kTestDisks[disk_info_index].is_parent,
- kTestDisks[disk_info_index].is_read_only,
+ kTestDisks[disk_info_index].is_read_only_hardware,
kTestDisks[disk_info_index].has_media,
kTestDisks[disk_info_index].on_boot_device,
kTestDisks[disk_info_index].on_removable_device,
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/private_api_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698