Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=

Committed: https://crrev.com/832439ab8f2aa933b6c3dc63aa7305bb5e803718
Cr-Commit-Position: refs/heads/master@{#40889}

[mythria, 2016-10-25 09:16:21]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:16:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mythria, 2016-10-25 09:18:26]

Description was changed from

==========
Fix FullCodeGen to include CallICs in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch
any bugs in future.

BUG=
==========

[mythria, 2016-10-25 09:18:40]

Description was changed from

==========
Fix FullCodeGen to include CallICs in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch
any bugs in future.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch any bugs in future.

BUG=
==========

[mythria, 2016-10-25 09:21:29]

mythria@chromium.org changed reviewers:
+ mvstanton@chromium.org, rmcilroy@chromium.org

[mythria, 2016-10-25 09:21:30]

This cl is to fix full-codegen to include CallICs when computing the
total_ic_count.I noticed this when the percentage of ICs with type feedback was
more than 100%. 

PTAL.

Thanks,
Mythri

[commit-bot: I haz the power, 2016-10-25 09:33:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 09:33:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[rmcilroy, 2016-10-25 09:39:04]

On 2016/10/25 09:21:30, mythria wrote:
> This cl is to fix full-codegen to include CallICs when computing the
> total_ic_count.I noticed this when the percentage of ICs with type feedback
was
> more than 100%. 
> 
> PTAL.
> 
> Thanks,
> Mythri

There still seems to be some >100% going on with some of the test failures on
the bots.

[mythria, 2016-10-26 10:04:50]

Description was changed from

==========
Fix FullCodeGen to include CallICs in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch any bugs in future.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch any bugs in future.

BUG=
==========

[mythria, 2016-10-26 10:05:10]

Description was changed from

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs. Also adds a DCHECK in runtime-profiler to possibly
catch any bugs in future.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=
==========

[mythria, 2016-10-26 10:05:24]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 10:05:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 10:30:46]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-10-26 10:40:02]

I fixed full-codegen to also account for calls to constructors. Even with that,
we still cannot add DCHECK in runtime-profiler for the total ic count for a
couple of reasons:

1. FullCodegen optimizes compares with undefined or null by eliminating the need
for a LoadGlobalIC (to load undefined/null) and a CompareIC. It generates the
code for comparing the maps inline (code here:
https://cs.chromium.org/chromium/src/v8/src/full-codegen/full-codegen.cc?sq=p...)
However, the type feedback vector already has these entries so the DCHECK fails.
I am not sure, if we need to "fix" it. 
If I add these into the total ic count, we also need to update the total ics
with feedback count appropriately. 

2. We get the total number of ics from the information on the Code object of
Function kind. When the function is marked for optimization, the code points to
a builtin and does not have this information. In most cases, we do not check for
IC counts when a function is marked for optimization, but if the function is
OSRed using turbofan, we hit this case. In this case, the function is not
optimized but we have an optimized frame. This is easily fixable.

I removed the DCHECK for now. Let me know if it is worth having the check given
that we need to hack a bit in full-codegen to have it.

[rmcilroy, 2016-10-26 14:20:37]

I don't know enough about the CallIC stuff to know why this wasn't a CallIC
originally. If Michael is happy it looks fine to me, thanks.

[mythria, 2016-11-09 11:52:35]

Hi Michael,

Fullcodegen did not count the calls to CallICs and CallConstructs in the total
ic count. So we were getting > 100% in the computed type percentages. I am not
sure if there was any particular reason why they were not counted earlier. Could
you PTAL.

Thanks,
Mythri

[mvstanton, 2016-11-09 13:13:36]

Right on, LGTM.

[mythria, 2016-11-10 11:43:44]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-11-10 11:43:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 12:10:45]

Description was changed from

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=
==========

[commit-bot: I haz the power, 2016-11-10 12:10:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:29:01]

Description was changed from

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=
==========

to

==========
Fix FullCodeGen to include CallICs and CallConstruct in the total ic count.

FullCodeGen does not include CallICs in the total ic count. Fix it by
making calls to CallIC to go through CallIC function, which keeps track
of the total number of ICs.

BUG=

Committed: https://crrev.com/832439ab8f2aa933b6c3dc63aa7305bb5e803718
Cr-Commit-Position: refs/heads/master@{#40889}
==========

[commit-bot: I haz the power, 2016-11-17 22:29:02]

Patchset 2 (id:??) landed as
https://crrev.com/832439ab8f2aa933b6c3dc63aa7305bb5e803718
Cr-Commit-Position: refs/heads/master@{#40889}