Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2451703002: Fix FullCodeGen to include CallICs and CallConstruct in the total ic count. (Closed)
Patch Set: Also count construct ICs in total_count. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 2274 matching lines...) Expand 10 before | Expand all | Expand 10 after
2285 } 2285 }
2286 // Update profiling counters before the tail call since we will 2286 // Update profiling counters before the tail call since we will
2287 // not return to this function. 2287 // not return to this function.
2288 EmitProfilingCounterHandlingForReturnSequence(true); 2288 EmitProfilingCounterHandlingForReturnSequence(true);
2289 } 2289 }
2290 Handle<Code> code = 2290 Handle<Code> code =
2291 CodeFactory::CallIC(isolate(), mode, expr->tail_call_mode()).code(); 2291 CodeFactory::CallIC(isolate(), mode, expr->tail_call_mode()).code();
2292 __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot())); 2292 __ Mov(x3, SmiFromSlot(expr->CallFeedbackICSlot()));
2293 __ Peek(x1, (arg_count + 1) * kXRegSize); 2293 __ Peek(x1, (arg_count + 1) * kXRegSize);
2294 __ Mov(x0, arg_count); 2294 __ Mov(x0, arg_count);
2295 __ Call(code, RelocInfo::CODE_TARGET); 2295 CallIC(code);
2296 OperandStackDepthDecrement(arg_count + 1); 2296 OperandStackDepthDecrement(arg_count + 1);
2297 2297
2298 RecordJSReturnSite(expr); 2298 RecordJSReturnSite(expr);
2299 RestoreContext(); 2299 RestoreContext();
2300 context()->DropAndPlug(1, x0); 2300 context()->DropAndPlug(1, x0);
2301 } 2301 }
2302 2302
2303 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) { 2303 void FullCodeGenerator::EmitResolvePossiblyDirectEval(Call* expr) {
2304 int arg_count = expr->arguments()->length(); 2304 int arg_count = expr->arguments()->length();
2305 ASM_LOCATION("FullCodeGenerator::EmitResolvePossiblyDirectEval"); 2305 ASM_LOCATION("FullCodeGenerator::EmitResolvePossiblyDirectEval");
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
2438 2438
2439 // Load function and argument count into x1 and x0. 2439 // Load function and argument count into x1 and x0.
2440 __ Mov(x0, arg_count); 2440 __ Mov(x0, arg_count);
2441 __ Peek(x1, arg_count * kXRegSize); 2441 __ Peek(x1, arg_count * kXRegSize);
2442 2442
2443 // Record call targets in unoptimized code. 2443 // Record call targets in unoptimized code.
2444 __ EmitLoadTypeFeedbackVector(x2); 2444 __ EmitLoadTypeFeedbackVector(x2);
2445 __ Mov(x3, SmiFromSlot(expr->CallNewFeedbackSlot())); 2445 __ Mov(x3, SmiFromSlot(expr->CallNewFeedbackSlot()));
2446 2446
2447 CallConstructStub stub(isolate()); 2447 CallConstructStub stub(isolate());
2448 __ Call(stub.GetCode(), RelocInfo::CODE_TARGET); 2448 CallIC(stub.GetCode());
2449 OperandStackDepthDecrement(arg_count + 1); 2449 OperandStackDepthDecrement(arg_count + 1);
2450 PrepareForBailoutForId(expr->ReturnId(), BailoutState::TOS_REGISTER); 2450 PrepareForBailoutForId(expr->ReturnId(), BailoutState::TOS_REGISTER);
2451 RestoreContext(); 2451 RestoreContext();
2452 context()->Plug(x0); 2452 context()->Plug(x0);
2453 } 2453 }
2454 2454
2455 2455
2456 void FullCodeGenerator::EmitSuperConstructorCall(Call* expr) { 2456 void FullCodeGenerator::EmitSuperConstructorCall(Call* expr) {
2457 ASM_LOCATION("FullCodeGenerator::EmitSuperConstructorCall"); 2457 ASM_LOCATION("FullCodeGenerator::EmitSuperConstructorCall");
2458 SuperCallReference* super_call_ref = 2458 SuperCallReference* super_call_ref =
(...skipping 1245 matching lines...) Expand 10 before | Expand all | Expand 10 after
3704 } 3704 }
3705 3705
3706 return INTERRUPT; 3706 return INTERRUPT;
3707 } 3707 }
3708 3708
3709 3709
3710 } // namespace internal 3710 } // namespace internal
3711 } // namespace v8 3711 } // namespace v8
3712 3712
3713 #endif // V8_TARGET_ARCH_ARM64 3713 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/full-codegen/arm/full-codegen-arm.cc ('k') | src/full-codegen/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698