Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2451693002: [wasm] Remove obsolete function name table (Closed)

Created:
4 years, 1 month ago by Clemens Hammacher
Modified:
4 years, 1 month ago
Reviewers:
titzer, ahaas
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove obsolete function name table The function name table is not used any more since https://chromiumcodereview.appspot.com/2424623002, so remove it. R=titzer@chromium.org,ahaas@chromium.org Committed: https://crrev.com/b1dec60bfae1f2b65e6ad6c7ab9276f4a13b598a Cr-Commit-Position: refs/heads/master@{#40552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -231 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D src/wasm/wasm-function-name-table.h View 1 chunk +0 lines, -33 lines 0 comments Download
D src/wasm/wasm-function-name-table.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/wasm/test-wasm-function-name-table.cc View 1 chunk +0 lines, -120 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Clemens Hammacher
4 years, 1 month ago (2016-10-25 08:47:54 UTC) #5
titzer
On 2016/10/25 08:47:54, Clemens Hammacher wrote: lgtm. Red is best :)
4 years, 1 month ago (2016-10-25 08:51:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451693002/1
4 years, 1 month ago (2016-10-25 08:57:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 08:59:40 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1dec60bfae1f2b65e6ad6c7ab9276f4a13b598a
Cr-Commit-Position: refs/heads/master@{#40552}

Powered by Google App Engine
This is Rietveld 408576698