Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: src/wasm/wasm-function-name-table.cc

Issue 2451693002: [wasm] Remove obsolete function name table (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-function-name-table.h ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-function-name-table.cc
diff --git a/src/wasm/wasm-function-name-table.cc b/src/wasm/wasm-function-name-table.cc
deleted file mode 100644
index cc52125500b9ed2b04e54249afd9546e6fd623f6..0000000000000000000000000000000000000000
--- a/src/wasm/wasm-function-name-table.cc
+++ /dev/null
@@ -1,71 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "src/wasm/wasm-function-name-table.h"
-
-#include "src/wasm/wasm-module.h"
-
-namespace v8 {
-namespace internal {
-namespace wasm {
-
-// Build an array with all function names. If there are N functions in the
-// module, then the first (kIntSize * (N+1)) bytes are integer entries.
-// The first integer entry encodes the number of functions in the module.
-// The entries 1 to N contain offsets into the second part of this array.
-// If a function is unnamed (not to be confused with an empty name), then the
-// integer entry is the negative offset of the next function name.
-// After these N+1 integer entries, the second part begins, which holds a
-// concatenation of all function names.
-Handle<ByteArray> BuildFunctionNamesTable(Isolate* isolate,
- const WasmModule* module) {
- uint64_t func_names_length = 0;
- for (auto& func : module->functions) func_names_length += func.name_length;
- int num_funcs_int = static_cast<int>(module->functions.size());
- int current_offset = (num_funcs_int + 1) * kIntSize;
- uint64_t total_array_length = current_offset + func_names_length;
- int total_array_length_int = static_cast<int>(total_array_length);
- // Check for overflow.
- CHECK(total_array_length_int == total_array_length && num_funcs_int >= 0 &&
- num_funcs_int == module->functions.size());
- Handle<ByteArray> func_names_array =
- isolate->factory()->NewByteArray(total_array_length_int, TENURED);
- func_names_array->set_int(0, num_funcs_int);
- int func_index = 0;
- for (const WasmFunction& fun : module->functions) {
- WasmName name = module->GetNameOrNull(&fun);
- if (name.start() == nullptr) {
- func_names_array->set_int(func_index + 1, -current_offset);
- } else {
- func_names_array->copy_in(current_offset,
- reinterpret_cast<const byte*>(name.start()),
- name.length());
- func_names_array->set_int(func_index + 1, current_offset);
- current_offset += name.length();
- }
- ++func_index;
- }
- return func_names_array;
-}
-
-MaybeHandle<String> GetWasmFunctionNameFromTable(
- Handle<ByteArray> func_names_array, uint32_t func_index) {
- uint32_t num_funcs = static_cast<uint32_t>(func_names_array->get_int(0));
- DCHECK(static_cast<int>(num_funcs) >= 0);
- Factory* factory = func_names_array->GetIsolate()->factory();
- DCHECK(func_index < num_funcs);
- int offset = func_names_array->get_int(func_index + 1);
- if (offset < 0) return {};
- int next_offset = func_index == num_funcs - 1
- ? func_names_array->length()
- : abs(func_names_array->get_int(func_index + 2));
- ScopedVector<byte> buffer(next_offset - offset);
- func_names_array->copy_out(offset, buffer.start(), next_offset - offset);
- if (!unibrow::Utf8::Validate(buffer.start(), buffer.length())) return {};
- return factory->NewStringFromUtf8(Vector<const char>::cast(buffer));
-}
-
-} // namespace wasm
-} // namespace internal
-} // namespace v8
« no previous file with comments | « src/wasm/wasm-function-name-table.h ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698