Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)
Patch Set: 2016-10-26T11:29:45 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/DragController.cpp
diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp
index 520d524322e63ad3a6f1bc3e0a2970d4f648473b..e20e000c37836e022d33d2f4bb449d9410decfb5 100644
--- a/third_party/WebKit/Source/core/page/DragController.cpp
+++ b/third_party/WebKit/Source/core/page/DragController.cpp
@@ -622,7 +622,9 @@ bool DragController::concludeEditDrag(DragData* dragData) {
innerFrame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
Xiaocheng 2016/10/26 05:49:18 We can remove it now.
yosin_UTC9 2016/10/26 07:43:07 Good catch! Done.
innerFrame->selection().setSelection(
- createVisibleSelection(range->startPosition(), range->endPosition()));
+ SelectionInDOMTree::Builder()
+ .setBaseAndExtent(EphemeralRange(range))
+ .build());
if (innerFrame->selection().isAvailable()) {
DCHECK(m_documentUnderMouse);
if (!innerFrame->editor().replaceSelectionAfterDraggingWithEvents(
« third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698