Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2451573005: Fix integer-overflow in dmg_fp::strtod (Closed)

Created:
4 years, 1 month ago by kcwu
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix integer-overflow in dmg_fp::strtod This is fixup of commit 094232aa BUG=659220 Committed: https://crrev.com/46a480d09ec3eaa4d5634bc9076b981e867b4ab8 Cr-Commit-Position: refs/heads/master@{#427751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/third_party/dmg_fp/dtoa.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/third_party/dmg_fp/exp_length.patch View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kcwu
4 years, 1 month ago (2016-10-26 13:15:14 UTC) #2
Lei Zhang
lgtm
4 years, 1 month ago (2016-10-26 18:10:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451573005/1
4 years, 1 month ago (2016-10-26 18:10:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:23:16 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:53:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46a480d09ec3eaa4d5634bc9076b981e867b4ab8
Cr-Commit-Position: refs/heads/master@{#427751}

Powered by Google App Engine
This is Rietveld 408576698