base/third_party/dmg_fp/exp_length.patch - Issue 2451573005: Fix integer-overflow in dmg_fp::strtod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/third_party/dmg_fp/exp_length.patch

Issue 2451573005: Fix integer-overflow in dmg_fp::strtod (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/third_party/dmg_fp/exp_length.patch

diff --git a/base/third_party/dmg_fp/exp_length.patch b/base/third_party/dmg_fp/exp_length.patch

index 7a6d691dfb0edff68130052430432e516c2d4a74..278ec17b2890e8b16a8dfb4cbecfdfc3bd47a473 100644

--- a/base/third_party/dmg_fp/exp_length.patch

+++ b/base/third_party/dmg_fp/exp_length.patch

@@ -10,7 +10,7 @@ index c0a51c2..ab4e056 100644

- L = 10*L + c - '0';

+ while((c = *++s) >= '0' && c <= '9') {

+ if (L < (INT_MAX - 10) / 10) {

-+ L = 10*L + c - '0';

++ L = 10*L + (c - '0');

+ }

if (s - s1 > 8 || L > 19999)

« no previous file with comments | « base/third_party/dmg_fp/dtoa.cc ('k') | no next file » | no next file with comments »