Not close bubble if the navigation is in-page

Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568
Committed: https://crrev.com/189740490f79e9c04c4fb06f8f5bdf80e8af977d
Cr-Commit-Position: refs/heads/master@{#427849}

[juncai, 2016-10-26 01:09:26]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 01:09:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:51:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:51:19]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-26 15:59:43]

Description was changed from

==========
Close bubble if load_details.is_in_page is false

This CL modifies code to close bubble if load_details.is_in_page is false.

BUG=614568
==========

to

==========
Close bubble if navigation is not in-page

This CL modifies code to close bubble if load_details.is_in_page is false.

BUG=614568
==========

[juncai, 2016-10-26 17:55:06]

Description was changed from

==========
Close bubble if navigation is not in-page

This CL modifies code to close bubble if load_details.is_in_page is false.

BUG=614568
==========

to

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to not close the
bubble when load_details.is_in_page is true.

BUG=614568
==========

[juncai, 2016-10-26 17:57:09]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-26 17:57:43]

Description was changed from

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to not close the
bubble when load_details.is_in_page is true.

BUG=614568
==========

to

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568
==========

[juncai, 2016-10-26 18:01:27]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 18:02:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-26 18:03:43]

juncai@chromium.org changed reviewers:
+ sky@chromium.org

[juncai, 2016-10-26 18:03:44]

Please take a look.

[commit-bot: I haz the power, 2016-10-26 18:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:54:37]

Dry run: This issue passed the CQ dry run.

[sky, 2016-10-26 19:20:48]

LGTM

https://codereview.chromium.org/2451573004/diff/40001/chrome/browser/ui/chrom...
File chrome/browser/ui/chrome_bubble_manager_unittest.cc (right):

https://codereview.chromium.org/2451573004/diff/40001/chrome/browser/ui/chrom...
chrome/browser/ui/chrome_bubble_manager_unittest.cc:76:
TEST_F(ChromeBubbleManagerTest, NotCloseMockBubbleWhenIsInPageNavigation) {
DontCloseBubbleWhenNavigationIsInPage.

[juncai, 2016-10-26 21:30:26]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[juncai, 2016-10-26 21:30:50]

https://codereview.chromium.org/2451573004/diff/40001/chrome/browser/ui/chrom...
File chrome/browser/ui/chrome_bubble_manager_unittest.cc (right):

https://codereview.chromium.org/2451573004/diff/40001/chrome/browser/ui/chrom...
chrome/browser/ui/chrome_bubble_manager_unittest.cc:76:
TEST_F(ChromeBubbleManagerTest, NotCloseMockBubbleWhenIsInPageNavigation) {
On 2016/10/26 19:20:48, sky wrote:
> DontCloseBubbleWhenNavigationIsInPage.

Done.

[commit-bot: I haz the power, 2016-10-26 21:31:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:20:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:20:13]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-26 22:22:42]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-10-26 22:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2451573004/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-10-26 22:23:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:28:59]

Description was changed from

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568
==========

to

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568
==========

[commit-bot: I haz the power, 2016-10-26 22:29:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-26 22:30:59]

Description was changed from

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568
==========

to

==========
Not close bubble if the navigation is in-page

This CL updates ChromeBubbleManager::NavigationEntryCommitted to
not close the bubble when load_details.is_in_page is true.

BUG=614568

Committed: https://crrev.com/189740490f79e9c04c4fb06f8f5bdf80e8af977d
Cr-Commit-Position: refs/heads/master@{#427849}
==========

[commit-bot: I haz the power, 2016-10-26 22:31:03]

Patchset 4 (id:??) landed as
https://crrev.com/189740490f79e9c04c4fb06f8f5bdf80e8af977d
Cr-Commit-Position: refs/heads/master@{#427849}