Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5367)

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 2451573004: Not close bubble if the navigation is in-page (Closed)
Patch Set: address comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_bubble_manager.cc
diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc
index 12b81029fa0bb8012bbcdf6b88c294b8e266dde9..1d9a9fda2122c5ad8875809566bf7275f7c70411 100644
--- a/chrome/browser/ui/chrome_bubble_manager.cc
+++ b/chrome/browser/ui/chrome_bubble_manager.cc
@@ -10,6 +10,7 @@
#include "components/bubble/bubble_controller.h"
#include "components/bubble/bubble_delegate.h"
#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_details.h"
#include "content/public/browser/web_contents.h"
namespace {
@@ -159,7 +160,8 @@ void ChromeBubbleManager::DidToggleFullscreenModeForTab(
void ChromeBubbleManager::NavigationEntryCommitted(
const content::LoadCommittedDetails& load_details) {
- CloseAllBubbles(BUBBLE_CLOSE_NAVIGATED);
+ if (!load_details.is_in_page)
+ CloseAllBubbles(BUBBLE_CLOSE_NAVIGATED);
}
void ChromeBubbleManager::ChromeBubbleMetrics::OnBubbleNeverShown(
« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698