chrome/browser/resources/settings/site_settings/site_data_details_dialog.js - Issue 2451553008: [MD settings] move cookie tree management to cookie tree behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

Issue 2451553008: [MD settings] move cookie tree management to cookie tree behavior (Closed)

Patch Set: cleanup extraneous if Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/cookie_tree_behavior.js ('K') | « chrome/browser/resources/settings/site_settings/site_data.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('j') | chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

index 06f4dd118552aa4af96268d35f82716017c608e2..3984f2099dfc6a57dd60c7b28e8d1a749bede783 100644

--- a/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

+++ b/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js

@@ -127,7 +127,7 @@ Polymer({

populateItem_: function(id, site) {

var node = site.fetchNodeById(id, true);

if (node)

- this.cookieNodes_ = site.getCookieData(node);

+ this.cookieNodes_ = getCookieData(node.data_);

Dan Beam 2016/10/27 01:31:55 why is this accessing a private member?

dschuyler 2016/10/27 20:47:35 I'd like to refactor the way the node data is fetc

/**