chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js - Issue 2451553008: [MD settings] move cookie tree management to cookie tree behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Issue 2451553008: [MD settings] move cookie tree management to cookie tree behavior (Closed)

Patch Set: cleanup extraneous if Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_data_details_dialog.js ('K') | « chrome/browser/resources/settings/site_settings/site_data_details_dialog.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

index 10e158411c77f2602376f05bb9c1e1f27600981c..1f3007d9786346239d6a66b248ca3648a36f0d42 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

@@ -157,7 +157,7 @@ cr.define('settings', function() {

/**

* Reloads all cookies.

- * @return {!Promise<Array<CookieDataSummaryItem>>} Returns the full cookie

+ * @return {!Promise<CookieList>} Returns the full cookie

Dan Beam 2016/10/27 01:31:55 arguably these should be !CookieList (unless they

dschuyler 2016/10/27 20:47:35 Done.

* list.

reloadCookies: function() {},

@@ -178,7 +178,7 @@ cr.define('settings', function() {

/**

* Removes all cookies.

- * @return {!Promise<Array<CookieDataSummaryItem>>} Returns the up to date

+ * @return {!Promise<CookieList>} Returns the up to date

* cookie list once deletion is complete (empty list).

removeAllCookies: function() {},