Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2451553003: Remove drmemory bots from master.client.pdfium (Closed)

Created:
4 years, 1 month ago by benwells
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, estaab
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, dsinclair, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, npm, Tom Sepez, Wei Li
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -386 lines) Patch
M masters/master.client.pdfium/builders.pyl View 2 chunks +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/pdfium.py View 3 chunks +1 line, -38 lines 0 comments Download
D scripts/slave/recipes/pdfium.expected/drm_win_xfa.json View 1 chunk +0 lines, -327 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
benwells
4 years, 1 month ago (2016-10-25 07:33:35 UTC) #2
Lei Zhang
lgtm, but you need OWNERS CC PDFium folks FYI.
4 years, 1 month ago (2016-10-25 07:41:51 UTC) #3
benwells
+estaab for owners review
4 years, 1 month ago (2016-10-25 11:00:07 UTC) #5
estaab
lgtm
4 years, 1 month ago (2016-10-25 16:45:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451553003/1
4 years, 1 month ago (2016-10-25 23:57:50 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 00:07:49 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/693fae79b585b4d1e120...

Powered by Google App Engine
This is Rietveld 408576698