Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: scripts/slave/recipes/pdfium.py

Issue 2451553003: Remove drmemory bots from master.client.pdfium (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.client.pdfium/builders.pyl ('k') | scripts/slave/recipes/pdfium.expected/drm_win_xfa.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/pdfium.py
diff --git a/scripts/slave/recipes/pdfium.py b/scripts/slave/recipes/pdfium.py
index b101d8188c19d0eefc253ea3894f5a1f1eb71184..0eb807f4eae634e4fd5f608d031b48df6b95516e 100644
--- a/scripts/slave/recipes/pdfium.py
+++ b/scripts/slave/recipes/pdfium.py
@@ -89,6 +89,7 @@ def _GNGenBuilds(api, memory_tool, skia, xfa, v8, target_cpu, clang, rel,
'--args=' + ' '.join(args)],
cwd=checkout)
+
def _BuildSteps(api, clang, out_dir):
# Build sample file using Ninja
debug_path = api.path['checkout'].join('out', out_dir)
@@ -102,34 +103,7 @@ def _BuildSteps(api, clang, out_dir):
api.step('compile with ninja', ninja_cmd)
-def _RunDrMemoryTests(api, v8):
- pdfium_tests_py = str(api.path['checkout'].join('tools',
- 'drmemory',
- 'scripts',
- 'pdfium_tests.py'))
- api.python('unittests', pdfium_tests_py,
- args=['--test', 'pdfium_unittests'],
- cwd=api.path['checkout'])
- api.python('embeddertests', pdfium_tests_py,
- args=['--test', 'pdfium_embeddertests'],
- cwd=api.path['checkout'])
- if v8:
- api.python('javascript tests', pdfium_tests_py,
- args=['--test', 'pdfium_javascript'],
- cwd=api.path['checkout'])
- api.python('pixel tests', pdfium_tests_py,
- args=['--test', 'pdfium_pixel'],
- cwd=api.path['checkout'])
- api.python('corpus tests', pdfium_tests_py,
- args=['--test', 'pdfium_corpus'],
- cwd=api.path['checkout'])
-
-
def _RunTests(api, memory_tool, v8, out_dir):
- if memory_tool == 'drmemory':
- _RunDrMemoryTests(api, v8)
- return
-
env = {}
if memory_tool == 'asan':
options = ['detect_leaks=1',
@@ -369,17 +343,6 @@ def GenTests(api):
)
yield (
- api.test('drm_win_xfa') +
- api.platform('win', 64) +
- api.properties(xfa=True,
- memory_tool='drmemory',
- target_cpu='x86',
- mastername="client.pdfium",
- buildername='drm_win_xfa',
- slavename="test_slave")
- )
-
- yield (
api.test('linux_xfa_asan_lsan') +
api.platform('linux', 64) +
api.properties(xfa=True,
« no previous file with comments | « masters/master.client.pdfium/builders.pyl ('k') | scripts/slave/recipes/pdfium.expected/drm_win_xfa.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698