Introduce Device Service

Introduce Device Service

This CL introduces the Device Service into //services/device along
with the infrastructure required in //content for the renderer to
connect to it and the browser to host it as an embedded service.

The service is currently empty. A followup CL will move the first
device-related service to be host in the Device Service instead of in
//content/browser.

BUG=612328
Committed: https://crrev.com/372d47d28a581be1a9baec3505b805d982129e37
Cr-Commit-Position: refs/heads/master@{#428904}

[blundell, 2016-10-27 20:03:44]

The CQ bit was checked by blundell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:04:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:23:41]

Dry run: This issue passed the CQ dry run.

[blundell, 2016-10-27 23:06:02]

blundell@chromium.org changed reviewers:
+ ben@chromium.org, rockot@chromium.org

[Ben Goodger (Google), 2016-10-27 23:49:38]

https://codereview.chromium.org/2451413003/diff/40001/content/public/app/mojo...
File content/public/app/mojo/content_renderer_manifest.json (right):

https://codereview.chromium.org/2451413003/diff/40001/content/public/app/mojo...
content/public/app/mojo/content_renderer_manifest.json:24: "service:device": [
"*" ],
Let's not use "*" - can you define a capability?

[blundell, 2016-10-28 21:03:02]

https://codereview.chromium.org/2451413003/diff/40001/content/public/app/mojo...
File content/public/app/mojo/content_renderer_manifest.json (right):

https://codereview.chromium.org/2451413003/diff/40001/content/public/app/mojo...
content/public/app/mojo/content_renderer_manifest.json:24: "service:device": [
"*" ],
On 2016/10/27 23:49:38, Ben Goodger (Google) wrote:
> Let's not use "*" - can you define a capability?

I just took this out for now. I'll add it in the next CL where I move a device
feature into the Device Service.

[Ben Goodger (Google), 2016-10-28 21:25:15]

lgtm

[Ken Rockot(use gerrit already), 2016-10-28 23:59:17]

lgtm

https://codereview.chromium.org/2451413003/diff/100001/services/device/device...
File services/device/device_service.h (right):

https://codereview.chromium.org/2451413003/diff/100001/services/device/device...
services/device/device_service.h:27: // |Service| override:
nitty style nit: Typically we fully qualify the interface name, and don't use
|-quoting

https://codereview.chromium.org/2451413003/diff/100001/services/device/manife...
File services/device/manifest.json (right):

https://codereview.chromium.org/2451413003/diff/100001/services/device/manife...
services/device/manifest.json:10: "*": [ "app" ]
nit: Might as well remove this too. We should add things as they're actually
needed.

[blundell, 2016-10-31 23:10:04]

The CQ bit was checked by blundell@chromium.org

[blundell, 2016-10-31 23:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2451413003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-31 23:10:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-10-31 23:11:56]

https://codereview.chromium.org/2451413003/diff/100001/services/device/device...
File services/device/device_service.h (right):

https://codereview.chromium.org/2451413003/diff/100001/services/device/device...
services/device/device_service.h:27: // |Service| override:
On 2016/10/28 23:59:17, Ken Rockot wrote:
> nitty style nit: Typically we fully qualify the interface name, and don't use
> |-quoting

Done.

https://codereview.chromium.org/2451413003/diff/100001/services/device/manife...
File services/device/manifest.json (right):

https://codereview.chromium.org/2451413003/diff/100001/services/device/manife...
services/device/manifest.json:10: "*": [ "app" ]
On 2016/10/28 23:59:17, Ken Rockot wrote:
> nit: Might as well remove this too. We should add things as they're actually
> needed.

Done.

[commit-bot: I haz the power, 2016-11-01 00:29:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:29:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[blundell, 2016-11-01 00:54:19]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:54:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:34:52]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-11-01 01:36:54]

Description was changed from

==========
Introduce Device Service

This CL introduces the Device Service into //services/device along
with the infrastructure required in //content for the renderer to
connect to it and the browser to host it as an embedded service.

The service is currently empty. A followup CL will move the first
device-related service to be host in the Device Service instead of in
//content/browser.

BUG=612328
==========

to

==========
Introduce Device Service

This CL introduces the Device Service into //services/device along
with the infrastructure required in //content for the renderer to
connect to it and the browser to host it as an embedded service.

The service is currently empty. A followup CL will move the first
device-related service to be host in the Device Service instead of in
//content/browser.

BUG=612328

Committed: https://crrev.com/372d47d28a581be1a9baec3505b805d982129e37
Cr-Commit-Position: refs/heads/master@{#428904}
==========

[commit-bot: I haz the power, 2016-11-01 01:36:55]

Patchset 8 (id:??) landed as
https://crrev.com/372d47d28a581be1a9baec3505b805d982129e37
Cr-Commit-Position: refs/heads/master@{#428904}