[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

BUG=658135
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/540e3bee8f50ff0a41c7dbece39890fbf1a661c7
Cr-Commit-Position: refs/heads/master@{#427928}

[Moe, 2016-10-26 23:07:49]

Description was changed from

==========
[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

BUG=658135
==========

to

==========
[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

BUG=658135
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-10-26 23:07:55]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 23:08:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-10-26 23:10:11]

mahmadi@chromium.org changed reviewers:
+ tommycli@chromium.org

[Moe, 2016-10-26 23:10:12]

Hi Tommy, Please review this CL. Do you know if we need to keep alt attrs for
a11y reason?s

[tommycli, 2016-10-27 00:17:15]

On 2016/10/26 23:10:12, moe wrote:
> Hi Tommy, Please review this CL. Do you know if we need to keep alt attrs for
> a11y reason?s

lgtm. I do think alt is more required than title. Maybe define both title and
alt? I think screenreaders read alt.

[tommycli, 2016-10-27 00:17:15]

On 2016/10/26 23:10:12, moe wrote:
> Hi Tommy, Please review this CL. Do you know if we need to keep alt attrs for
> a11y reason?s

lgtm. I do think alt is more required than title. Maybe define both title and
alt? I think screenreaders read alt.

[tommycli, 2016-10-27 00:17:42]

tommycli@chromium.org changed reviewers:
+ hcarmona@chromium.org

[tommycli, 2016-10-27 00:17:42]

+hcarmona@ for alt vs title accessibility Q

[commit-bot: I haz the power, 2016-10-27 00:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 00:47:18]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-10-27 01:26:54]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-27 01:26:55]

iirc, using title instead of alt (like you're doing) is fine

you can use voiceover on your mac book pro (Cmd+F5) to test if you want

[Moe, 2016-10-27 03:24:39]

On 2016/10/27 01:26:55, Dan Beam wrote:
> iirc, using title instead of alt (like you're doing) is fine
> 
> you can use voiceover on your mac book pro (Cmd+F5) to test if you want

I can't quite get ChromeVox on chromeos build to talk, voiceover seems to pick
up the title in this fiddle: https://jsfiddle.net/kc9c5fmd/. So let's go ahead
with it.

[Moe, 2016-10-27 03:24:47]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:25:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-10-27 03:28:29]

On 2016/10/27 03:25:05, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

sorry, this one: https://jsfiddle.net/20nwvn3h/

[commit-bot: I haz the power, 2016-10-27 03:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 03:32:41]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-27 03:35:27]

Description was changed from

==========
[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

BUG=658135
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][People] Fixes picture tooltips and sizes in change picture page.

BUG=658135
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/540e3bee8f50ff0a41c7dbece39890fbf1a661c7
Cr-Commit-Position: refs/heads/master@{#427928}
==========

[commit-bot: I haz the power, 2016-10-27 03:35:28]

Patchset 1 (id:??) landed as
https://crrev.com/540e3bee8f50ff0a41c7dbece39890fbf1a661c7
Cr-Commit-Position: refs/heads/master@{#427928}