Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2757)

Unified Diff: chrome/browser/resources/settings/people_page/change_picture.html

Issue 2451373002: [MD Settings][People] Fixes picture tooltips and sizes in change picture page. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/change_picture.html
diff --git a/chrome/browser/resources/settings/people_page/change_picture.html b/chrome/browser/resources/settings/people_page/change_picture.html
index f0460f60329be2081c2d23166496a965a47cdc4f..396e51654b2318166a20bf16553fbd1e1271064d 100644
--- a/chrome/browser/resources/settings/people_page/change_picture.html
+++ b/chrome/browser/resources/settings/people_page/change_picture.html
@@ -21,6 +21,10 @@
padding-top: 16px;
}
+ #availableIcons {
+ margin: -8px;
+ }
+
#availableIcons img,
#availableIcons iron-icon {
border-radius: 4px;
@@ -35,6 +39,9 @@
}
#availableIcons iron-icon {
+ --iron-icon-fill-color: var(--google-grey-500);
+ --iron-icon-height: 32px;
+ --iron-icon-width: 32px;
border: 1px solid var(--google-grey-500);
padding: 17px;
}
@@ -92,21 +99,21 @@
selected-item="{{selectedItem_}}">
<iron-icon id="cameraImage"
data-type$="[[selectionTypesEnum_.CAMERA]]"
- icon="settings:camera-alt" alt="$i18n{takePhoto}"
+ icon="settings:camera-alt" title="$i18n{takePhoto}"
hidden="[[!cameraPresent_]]">
</iron-icon>
<iron-icon data-type$="[[selectionTypesEnum_.FILE]]"
- icon="settings:folder" alt="$i18n{chooseFile}">
+ icon="settings:folder" title="$i18n{chooseFile}">
</iron-icon>
<img id="profileImage"
data-type$="[[selectionTypesEnum_.PROFILE]]"
- src="[[profileImageUrl_]]" alt="$i18n{profilePhotoLoading}">
+ src="[[profileImageUrl_]]" title="$i18n{profilePhotoLoading}">
<img id="oldImage" data-type$="[[selectionTypesEnum_.OLD]]"
src="[[oldImageUrl_]]" hidden="[[!oldImageUrl_]]">
<template is="dom-repeat" items="[[defaultImages_]]">
<img data-type$="[[selectionTypesEnum_.DEFAULT]]"
data-default-image-index$="[[index]]" src="[[item.url]]"
- alt="[[item.title]]">
+ title="[[item.title]]">
</template>
</iron-selector>
<template is="dom-if" if="[[isAuthorCreditShown_(selectedItem_)]]">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698