Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2451223003: Split SetFixedSize and SetDirectionTriggersScrollbar in multiple functions. (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split SetFixedSize and SetDirectionTriggersScrollbar in multiple functions. This is a follow up patch that fixes https://codereview.chromium.org/2446243003/#msg11 comment and a couple of compiler warnings about unitialized values. BUG=635619 Committed: https://crrev.com/7a997dfad6e963e9f666c9bd3fcc76fc7531c58d Cr-Commit-Position: refs/heads/master@{#427920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -25 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h View 2 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc View 3 chunks +34 lines, -17 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Gleb Lanbin
4 years, 1 month ago (2016-10-26 23:02:36 UTC) #3
ikilpatrick
lgtm
4 years, 1 month ago (2016-10-26 23:03:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451223003/20001
4 years, 1 month ago (2016-10-27 02:34:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-10-27 02:41:27 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 02:43:39 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a997dfad6e963e9f666c9bd3fcc76fc7531c58d
Cr-Commit-Position: refs/heads/master@{#427920}

Powered by Google App Engine
This is Rietveld 408576698