Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2451223003: Split SetFixedSize and SetDirectionTriggersScrollbar in multiple functions. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
index 3faff1605894d7a3838499181c622668a6c886ce..db9a641c820f6dafe1d5f46feb98db8178254151 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
@@ -16,10 +16,15 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
NGConstraintSpaceBuilder(NGWritingMode writing_mode);
NGConstraintSpaceBuilder& SetContainerSize(NGLogicalSize container_size);
- NGConstraintSpaceBuilder& SetFixedSize(bool fixed_inline, bool fixed_block);
- NGConstraintSpaceBuilder& SetOverflowTriggersScrollbar(
- bool inline_direction_triggers_scrollbar,
- bool block_direction_triggers_scrollbar);
+
+ NGConstraintSpaceBuilder& SetIsFixedSizeInline(bool is_fixed_size_inline);
+ NGConstraintSpaceBuilder& SetIsFixedSizeBlock(bool is_fixed_size_block);
+
+ NGConstraintSpaceBuilder& SetIsInlineDirectionTriggersScrollbar(
+ bool is_inline_direction_triggers_scrollbar);
+ NGConstraintSpaceBuilder& SetIsBlockDirectionTriggersScrollbar(
+ bool is_block_direction_triggers_scrollbar);
+
NGConstraintSpaceBuilder& SetFragmentationType(NGFragmentationType);
NGConstraintSpaceBuilder& SetIsNewFormattingContext(bool is_new_fc);
@@ -40,10 +45,10 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
const unsigned writing_mode_ : 2;
// mutable bit fields.
- unsigned fixed_inline_ : 1;
- unsigned fixed_block_ : 1;
- unsigned inline_direction_triggers_scrollbar_ : 1;
- unsigned block_direction_triggers_scrollbar_ : 1;
+ unsigned is_fixed_size_inline_ : 1;
+ unsigned is_fixed_size_block_ : 1;
+ unsigned is_inline_direction_triggers_scrollbar_ : 1;
+ unsigned is_block_direction_triggers_scrollbar_ : 1;
unsigned fragmentation_type_ : 2;
unsigned is_new_fc_ : 1;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698