[debugger] Add initial skeleton for debug test wrapper

[debugger] Add initial skeleton for debug test wrapper

This adds a wrapper class around the inspector protocol for use in
debugger tests. The interface is intended to stay similar to the
currently exposed DebuggerContext.

Right now, we support adding a listener, (partial) handling of the
AfterCompile event, and enabling/disabling the debugger.

BUG=v8:5530
Committed: https://crrev.com/c8d2a8cf161e3488073f23a560fcfa8c6b13b841
Cr-Commit-Position: refs/heads/master@{#40635}

[jgruber, 2016-10-27 09:39:15]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 09:39:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-27 09:49:26]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 09:49:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-27 09:53:26]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-27 09:53:27]

Initial go at a wrapper. Many details are still unclear, such as how to support
the listener exec_state argument. Received replies are currently stored by ID
forever - I'm guessing we don't really care about this since the wrapper is only
used for tests anyways.

Comments welcome, ptal.

[commit-bot: I haz the power, 2016-10-27 10:13:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 10:13:45]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-28 04:57:06]

We could use a queue (Array push and shift) to store the messages if you worry
about keeping all the strings alive.

I thought about using async/await and Promises to better handle sending and
receiving messages. While it would be a lot more convenient to use, it would
probably not work for the way our test cases are written. So let's not do that.

LGTM.

https://codereview.chromium.org/2451153003/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2451153003/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:6: const printProtocolMessages = false;
Let's put this script in strict mode.

[jgruber, 2016-10-28 06:54:53]

On 2016/10/28 04:57:06, Yang wrote:
> We could use a queue (Array push and shift) to store the messages if you worry
> about keeping all the strings alive.

I thought about that, but it's easier to handle the async-sync API conversion
when
we can access replies by ID.

[jgruber, 2016-10-28 06:55:01]

https://codereview.chromium.org/2451153003/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2451153003/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:6: const printProtocolMessages = false;
On 2016/10/28 04:57:06, Yang wrote:
> Let's put this script in strict mode.

Done.

[jgruber, 2016-10-28 06:55:15]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-10-28 06:55:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2451153003/#ps40001
(title: "Put test-api.js in strict mode")

[commit-bot: I haz the power, 2016-10-28 06:55:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 07:21:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:16:16]

Description was changed from

==========
[debugger] Add initial skeleton for debug test wrapper

This adds a wrapper class around the inspector protocol for use in
debugger tests. The interface is intended to stay similar to the
currently exposed DebuggerContext.

Right now, we support adding a listener, (partial) handling of the
AfterCompile event, and enabling/disabling the debugger.

BUG=v8:5530
==========

to

==========
[debugger] Add initial skeleton for debug test wrapper

This adds a wrapper class around the inspector protocol for use in
debugger tests. The interface is intended to stay similar to the
currently exposed DebuggerContext.

Right now, we support adding a listener, (partial) handling of the
AfterCompile event, and enabling/disabling the debugger.

BUG=v8:5530

Committed: https://crrev.com/c8d2a8cf161e3488073f23a560fcfa8c6b13b841
Cr-Commit-Position: refs/heads/master@{#40635}
==========

[commit-bot: I haz the power, 2016-11-17 22:16:17]

Patchset 3 (id:??) landed as
https://crrev.com/c8d2a8cf161e3488073f23a560fcfa8c6b13b841
Cr-Commit-Position: refs/heads/master@{#40635}