[debugger] Various break-related functionality in test wrapper

[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
Committed: https://crrev.com/83b560b0e5cf69cdd489ae318d3bdbf229b82932
Cr-Commit-Position: refs/heads/master@{#40636}

[jgruber, 2016-10-27 14:05:06]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:05:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-10-27 14:13:40]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2016-10-27 14:13:41]

This includes a bit more functionality around breakpoints, stepping and
evaluation.

Any ideas for a better directory name than test/debugger/debugger/?

[commit-bot: I haz the power, 2016-10-27 14:21:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 14:21:07]

Dry run: Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15364)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[jgruber, 2016-10-27 14:48:11]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 14:48:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 15:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 15:12:30]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-28 05:51:06]

Very nice! LGTM.

https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:61: assertTrue(!!script.id);
This still relies on the script wrapper object, which we want to eventually
remove from messages.js

Could we have a %FunctionGetScriptId that returns the script id directly, and
mark %FunctionGetScript as to-be-removed with a TODO?

[jgruber, 2016-10-28 06:43:08]

Description was changed from

==========
[debugger] Simple handling of various break-related functionality

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
==========

to

==========
[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
==========

[jgruber, 2016-10-28 07:36:27]

https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api.js
File test/debugger/test-api.js (right):

https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api....
test/debugger/test-api.js:61: assertTrue(!!script.id);
On 2016/10/28 05:51:06, Yang wrote:
> This still relies on the script wrapper object, which we want to eventually
> remove from messages.js
> 
> Could we have a %FunctionGetScriptId that returns the script id directly, and
> mark %FunctionGetScript as to-be-removed with a TODO?

Done.

[Yang, 2016-10-28 07:44:56]

On 2016/10/28 07:36:27, jgruber wrote:
>
https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api.js
> File test/debugger/test-api.js (right):
> 
>
https://codereview.chromium.org/2447073007/diff/20001/test/debugger/test-api....
> test/debugger/test-api.js:61: assertTrue(!!script.id);
> On 2016/10/28 05:51:06, Yang wrote:
> > This still relies on the script wrapper object, which we want to eventually
> > remove from messages.js
> > 
> > Could we have a %FunctionGetScriptId that returns the script id directly,
and
> > mark %FunctionGetScript as to-be-removed with a TODO?
> 
> Done.

lgtm.

[jgruber, 2016-10-28 07:45:26]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-10-28 07:45:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 08:18:14]

Description was changed from

==========
[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
==========

to

==========
[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
==========

[commit-bot: I haz the power, 2016-10-28 08:18:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-17 22:16:20]

Description was changed from

==========
[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530
==========

to

==========
[debugger] Various break-related functionality in test wrapper

This CL adds simple implementation of break and stepping-related functionality
as required by the debug-step.js test. This includes

* stepOver, stepInto, stepOut
* setBreakPoint
* clearBreakPoint
* evaluate

Some of these, e.g. setBreakPoint are not fully implemented for all cases but
only for the ones we need right now.

One interesting result of this is that using the inspector protocol is roughly
14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
be iteration over all object properties in toProtocolValue, which is used to
serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
is something that should be fixed at some point. In the meantime, the test now
runs 100 instead of 1000 iterations.

BUG=v8:5530

Committed: https://crrev.com/83b560b0e5cf69cdd489ae318d3bdbf229b82932
Cr-Commit-Position: refs/heads/master@{#40636}
==========

[commit-bot: I haz the power, 2016-11-17 22:16:21]

Patchset 4 (id:??) landed as
https://crrev.com/83b560b0e5cf69cdd489ae318d3bdbf229b82932
Cr-Commit-Position: refs/heads/master@{#40636}