Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2451133002: [promises] Remove FulfillPromise (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Remove FulfillPromise This patch replaces it with calls to the runtime function and PromiseSet. This allows us to move PromiseReject to C++ without regressions. BUG=v8:5343 Committed: https://crrev.com/87ec1673e4e389943df4bc1473ca27e21f54e2c7 Cr-Commit-Position: refs/heads/master@{#40589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/js/promise.js View 4 chunks +7 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
gsathya
4 years, 1 month ago (2016-10-26 10:56:18 UTC) #4
adamk
What's the advantage of this approach over just moving PromiseSet to C++ right now?
4 years, 1 month ago (2016-10-26 12:01:50 UTC) #7
gsathya
On 2016/10/26 12:01:50, adamk wrote: > What's the advantage of this approach over just moving ...
4 years, 1 month ago (2016-10-26 12:23:58 UTC) #8
adamk
lgtm if you add that explanation to the CL description
4 years, 1 month ago (2016-10-26 12:42:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451133002/1
4 years, 1 month ago (2016-10-26 12:43:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 12:45:35 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87ec1673e4e389943df4bc1473ca27e21f54e2c7
Cr-Commit-Position: refs/heads/master@{#40589}

Powered by Google App Engine
This is Rietveld 408576698