Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2446113007:
[promises] remove kPending check in RejectPromise (Closed)
Description[promises] remove kPending check in RejectPromise
RejectPromise is always called on a pending promise making this a redundant check.
BUG=v8:5343
Committed: https://crrev.com/a7a350012c05f644f3f373fb48d7ac72f7f60542
Cr-Commit-Position: refs/heads/master@{#40591}
Patch Set 1 #
Total comments: 1
Patch Set 2 : fmt #
Depends on Patchset: Messages
Total messages: 18 (13 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gsathya@chromium.org changed reviewers: + adamk@chromium.org
Description was changed from ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG= ========== to ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG=v8:5343 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % formatting https://codereview.chromium.org/2446113007/diff/1/src/js/promise.js File src/js/promise.js (right): https://codereview.chromium.org/2446113007/diff/1/src/js/promise.js#newcode313 src/js/promise.js:313: %PromiseRejectEvent(promise, reason, debugEvent); Nit: indentation is off.
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by gsathya@chromium.org
The CQ bit was checked by gsathya@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2446113007/#ps20001 (title: "fmt")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG=v8:5343 ========== to ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG=v8:5343 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG=v8:5343 ========== to ========== [promises] remove kPending check in RejectPromise RejectPromise is always called on a pending promise making this a redundant check. BUG=v8:5343 Committed: https://crrev.com/a7a350012c05f644f3f373fb48d7ac72f7f60542 Cr-Commit-Position: refs/heads/master@{#40591} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a7a350012c05f644f3f373fb48d7ac72f7f60542 Cr-Commit-Position: refs/heads/master@{#40591} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
