chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc - Issue 245113003: Removed dependency on the UI from the NetworkPortalDetector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

Issue 245113003: Removed dependency on the UI from the NetworkPortalDetector. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_impl.cc ('k') | chrome/browser/chromeos/net/network_portal_detector_strategy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

index 20fb4b901aae2d9307c7ccda1ab66d047719a5a2..d83eaae3ea06596dfc62c10ddec2bd7902e75bc3 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

@@ -14,6 +14,7 @@

#include "base/metrics/statistics_recorder.h"

#include "base/run_loop.h"

#include "chrome/browser/chromeos/net/network_portal_detector_impl.h"

+#include "chrome/browser/chromeos/net/network_portal_detector_strategy.h"

#include "chrome/browser/chromeos/net/network_portal_detector_test_utils.h"

#include "chrome/test/base/testing_profile.h"

#include "chromeos/chromeos_switches.h"

@@ -134,11 +135,13 @@ class NetworkPortalDetectorImplTest

}

void enable_error_screen_strategy() {

- network_portal_detector()->OnErrorScreenShow();

+ network_portal_detector()->SetStrategy(

+ PortalDetectorStrategy::STRATEGY_ID_ERROR_SCREEN);

}

void disable_error_screen_strategy() {

- network_portal_detector()->OnErrorScreenHide();

+ network_portal_detector()->SetStrategy(

+ PortalDetectorStrategy::STRATEGY_ID_LOGIN_SCREEN);

}

void stop_detection() { network_portal_detector()->StopDetection(); }