Chromium Code Reviews| Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc |
| diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc |
| index cc7c17675c76c57d530ddd8c3df0e8bd272f3885..05a401638115229c81e8668d2bd1356bed4a9c9e 100644 |
| --- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc |
| +++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc |
| @@ -349,6 +349,13 @@ bool RunArcExternalProtocolDialog(const GURL& url, |
| // This function is for external protocols that Chrome cannot handle. |
| DCHECK(!url.SchemeIsHTTPOrHTTPS()) << url; |
| + // Handle client-side redirections. Forwarding such navigations to ARC is |
| + // better than just showing the "can't open" dialog. |
| + // TODO(djacobo): Check if doing this in arc::ShouldIgnoreNavigation is safe, |
| + // and move it to the function if it is. (b/32442730#comment3) |
|
djacobo_
2016/10/26 22:41:06
I will, thanks!
|
| + page_transition = ui::PageTransitionFromInt( |
| + page_transition & ~ui::PAGE_TRANSITION_CLIENT_REDIRECT); |
| + |
| // Try to forward <form> submissions to ARC when possible. |
| constexpr bool kAllowFormSubmit = true; |
| if (ShouldIgnoreNavigation(page_transition, kAllowFormSubmit)) |