Handle navigations with PAGE_TRANSITION_CLIENT_REDIRECT qualifier

chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
@@ skipping 331 matching lines @@
 }  // namespace
 
 bool RunArcExternalProtocolDialog(const GURL& url,
                                   int render_process_host_id,
                                   int routing_id,
                                   ui::PageTransition page_transition,
                                   bool has_user_gesture) {
   // This function is for external protocols that Chrome cannot handle.
   DCHECK(!url.SchemeIsHTTPOrHTTPS()) << url;
 
+  // Handle client-side redirections. Forwarding such navigations to ARC is
+  // better than just showing the "can't open" dialog.
+  // TODO(djacobo): Check if doing this in arc::ShouldIgnoreNavigation is safe,
+  // and move it to the function if it is. (b/32442730#comment3)

[djacobo_, 2016/10/26 22:41:06]

I will, thanks!

+  page_transition = ui::PageTransitionFromInt(
+      page_transition & ~ui::PAGE_TRANSITION_CLIENT_REDIRECT);
+
   // Try to forward <form> submissions to ARC when possible.
   constexpr bool kAllowFormSubmit = true;
   if (ShouldIgnoreNavigation(page_transition, kAllowFormSubmit))
     return false;
 
   auto* instance = ArcIntentHelperBridge::GetIntentHelperInstance(
       "RequestUrlHandlerList", kMinVersionForRequestUrlHandlerList);
   if (!instance)
     return false;  // ARC is either not supported or not yet ready.
 
@@ skipping 15 matching lines @@
 GetActionResult GetActionForTesting(
     const GURL& original_url,
     const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
     size_t selected_app_index,
     std::pair<GURL, std::string>* out_url_and_package) {
   return GetAction(original_url, handlers, selected_app_index,
                    out_url_and_package);
 }
 
 }  // namespace arc