Issue 245103004: Remove dead code from childIndex optimization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245103004: Remove dead code from childIndex optimization (Closed)

Created:
6 years, 8 months ago by esprehn

Modified:
6 years, 8 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, ojan

CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, ojan, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove dead code from childIndex optimization We used to use the childIndex in the DOMSiblingTraversalStrategy but leviw@ removed it to fix a bug after he reversed the direction we did recalcStyle in r160288 and r158839. We're going to need something like this eventually, but I think we want something even better than this old optimization since it didn't help querySelector at all. Lets just delete this code for now while we figure out the right way to optimize nth-child selectors. BUG=364081 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172105

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -26 lines)			Patch
M	Source/core/css/SelectorChecker.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/Element.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	Source/core/dom/ElementRareData.h	View	4 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/245103004/1

6 years, 8 months ago (2014-04-21 22:57:00 UTC) #3

Message was sent while issue was closed.

Change committed as 172105

Expand Messages | Collapse Messages