chromeos: Avoid crash on synchronous suspend readiness call.

chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=chrome-os-partner:58295, 648580
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)

[Daniel Erat, 2016-10-25 23:24:16]

derat@chromium.org changed reviewers:
+ chirantan@chromium.org

[Chirantan Ekbote, 2016-10-25 23:27:25]

lgtm

[Daniel Erat, 2016-10-25 23:30:39]

Description was changed from

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=chrome-os-partner:58295,648580
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
==========

to

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=chrome-os-partner:58295,648580
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
==========

[Daniel Erat, 2016-10-25 23:37:41]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-25 23:38:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 23:41:10]

Description was changed from

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=chrome-os-partner:58295,648580
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
==========

to

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

(Unit tests omitted for merge to M54 since they depend on
additional changes.)

BUG=chrome-os-partner:58295,648580
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2403733003
Cr-Commit-Position: refs/heads/master@{#424214}
(cherry picked from commit 2e1f06081912f24add12275fc184f1995011faed)
==========

[commit-bot: I haz the power, 2016-10-25 23:41:11]

Committed patchset #1 (id:1)