chromeos: Avoid crash on synchronous suspend readiness call.

chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

BUG=chrome-os-partner:58295, 648580
Committed: https://crrev.com/2e1f06081912f24add12275fc184f1995011faed
Cr-Commit-Position: refs/heads/master@{#424214}

[Daniel Erat, 2016-10-10 18:47:49]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 18:48:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2016-10-10 18:49:19]

derat@chromium.org changed reviewers:
+ chirantan@chromium.org

[Daniel Erat, 2016-10-10 18:49:20]

this feels lower-risk to me than fixing DisplayConfigurator, so i'd prefer to
check it in first (since it may need to be merged).

[Chirantan Ekbote, 2016-10-10 19:23:08]

lgtm

[commit-bot: I haz the power, 2016-10-10 19:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 19:31:07]

Dry run: This issue passed the CQ dry run.

[Daniel Erat, 2016-10-10 20:00:19]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-10-10 20:00:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 20:06:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-10 20:09:22]

Description was changed from

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

BUG=chrome-os-partner:58295,648580
==========

to

==========
chromeos: Avoid crash on synchronous suspend readiness call.

Avoid a CHECK() (and premature HandleSuspendReadiness D-Bus
call to powerd) in
PowerManagerClient::MaybeReportSuspendReadiness that could
happen when a PowerManagerClient::Observer called
GetSuspendReadinessCallback() and then invoked the callback
synchronously from its SuspendImminent() method instead of
running it asynchronously. It appears that
DisplayConfigurator does this in some no-op cases.

BUG=chrome-os-partner:58295,648580

Committed: https://crrev.com/2e1f06081912f24add12275fc184f1995011faed
Cr-Commit-Position: refs/heads/master@{#424214}
==========

[commit-bot: I haz the power, 2016-10-10 20:09:23]

Patchset 1 (id:??) landed as
https://crrev.com/2e1f06081912f24add12275fc184f1995011faed
Cr-Commit-Position: refs/heads/master@{#424214}