|
|
Created:
4 years, 1 month ago by vakh (use Gerrit instead) Modified:
3 years, 5 months ago Reviewers:
rkaplow CC:
chromium-reviews, vakh+watch_chromium.org, Alexei Svitkine (slow), rkaplow Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the testing config with the new experiments for PVer4.
Google CLs: http://cl/137190961, http://cl/137192202
BUG=543161
Review-Url: https://codereview.chromium.org/2450963002
Cr-Commit-Position: refs/heads/master@{#486392}
Committed: https://chromium.googlesource.com/chromium/src/+/dee0b4dc2f1538b274616ab361a4e03781dd28db
Patch Set 1 #Patch Set 2 : Fix silly typos #
Total comments: 1
Patch Set 3 : Make V4Hybrid the first group so that it receives testing #
Total comments: 1
Patch Set 4 : Rebase and enable V4Only2 #Patch Set 5 : rebase #Patch Set 6 : Add a method to check whether SubResource filter can be checked #Patch Set 7 : rebase #Messages
Total messages: 111 (84 generated)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fix silly typos
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Remove unintended change
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update the testing config with the new experiments for PVer4. BUG=543161 ========== to ========== Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ==========
vakh@chromium.org changed reviewers: + asvitkine@chromium.org, rkaplow@chromium.org
asvitkine@chromium.org or rkaplow@chromium.org: Please review changes in testing/variations/fieldtrial_testing_config.json
https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fiel... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fiel... testing/variations/fieldtrial_testing_config.json:1714: "name": "V4Hybrid", The first group is the one that receives testing. So suggest putting V4Hybrid first if it's the one you're planning to launch.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Make V4Hybrid the first group so that it receives testing
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
On 2016/10/25 20:33:10, Alexei Svitkine (slow) wrote: > https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fiel... > File testing/variations/fieldtrial_testing_config.json (right): > > https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fiel... > testing/variations/fieldtrial_testing_config.json:1714: "name": "V4Hybrid", > The first group is the one that receives testing. So suggest putting V4Hybrid > first if it's the one you're planning to launch. Thanks for the insight. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm https://codereview.chromium.org/2450963002/diff/60001/testing/variations/fiel... File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2450963002/diff/60001/testing/variations/fiel... testing/variations/fieldtrial_testing_config.json:1701: "name": "V4Hybrid", I actually think it makes more sense to have it alone, and not have the other two - since right now it isn't functional and can confuse people into thinking that they are tested.
Description was changed from ========== Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ========== to ========== DO NOT SUBMIT (yet): Since browser tests are not ready for the V4Hybrid mode. Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ==========
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Rebase and enable V4Only2
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Seems like there's test failures?
On 2017/01/27 at 22:04:47, asvitkine wrote: > Seems like there's test failures? Yes, working on fixing them. I'm going to move rkaplow@ and you to CC until I fix these issues. rkaplow@ -- feel free to withdraw LGTM.
vakh@chromium.org changed reviewers: - asvitkine@chromium.org, rkaplow@chromium.org
rkaplow@chromium.org changed reviewers: + rkaplow@chromium.org
not too worried about it :) readd one of us when you are ready to submit
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rebase
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rebase
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Patchset #5 (id:100001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by vakh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2450963002/#ps120001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Add a method to check whether SubResource filter can be checked
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
rebase
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== DO NOT SUBMIT (yet): Since browser tests are not ready for the V4Hybrid mode. Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ========== to ========== Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ==========
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
test
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Add debug information for failing tests
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
rebase
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Remove erroneously added ORing of true
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Patchset #10 (id:220001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #7 (id:160001) has been deleted
Patchset #7 (id:180001) has been deleted
Patchset #7 (id:200001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
rebase
The CQ bit was checked by vakh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vakh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2450963002/#ps280001 (title: "rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vakh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 280001, "attempt_start_ts": 1499958150242580, "parent_rev": "944975a0b6009211490a960f54530452c73dfb96", "commit_rev": "dee0b4dc2f1538b274616ab361a4e03781dd28db"}
Message was sent while issue was closed.
Description was changed from ========== Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 ========== to ========== Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 Review-Url: https://codereview.chromium.org/2450963002 Cr-Commit-Position: refs/heads/master@{#486392} Committed: https://chromium.googlesource.com/chromium/src/+/dee0b4dc2f1538b274616ab361a4... ==========
Message was sent while issue was closed.
Committed patchset #9 (id:280001) as https://chromium.googlesource.com/chromium/src/+/dee0b4dc2f1538b274616ab361a4...
Message was sent while issue was closed.
Patchset #8 (id:260001) has been deleted
Message was sent while issue was closed.
Patchset #7 (id:240001) has been deleted |