Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2450963002: Update the testing config with the new experiments for PVer4. (Closed)

Created:
4 years, 1 month ago by vakh (use Gerrit instead)
Modified:
3 years, 5 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, vakh+watch_chromium.org, Alexei Svitkine (slow), rkaplow
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the testing config with the new experiments for PVer4. Google CLs: http://cl/137190961, http://cl/137192202 BUG=543161 Review-Url: https://codereview.chromium.org/2450963002 Cr-Commit-Position: refs/heads/master@{#486392} Committed: https://chromium.googlesource.com/chromium/src/+/dee0b4dc2f1538b274616ab361a4e03781dd28db

Patch Set 1 #

Patch Set 2 : Fix silly typos #

Total comments: 1

Patch Set 3 : Make V4Hybrid the first group so that it receives testing #

Total comments: 1

Patch Set 4 : Rebase and enable V4Only2 #

Patch Set 5 : rebase #

Patch Set 6 : Add a method to check whether SubResource filter can be checked #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 111 (84 generated)
vakh (use Gerrit instead)
Fix silly typos
4 years, 1 month ago (2016-10-25 20:18:02 UTC) #3
vakh (use Gerrit instead)
Remove unintended change
4 years, 1 month ago (2016-10-25 20:19:15 UTC) #6
vakh (use Gerrit instead)
asvitkine@chromium.org or rkaplow@chromium.org: Please review changes in testing/variations/fieldtrial_testing_config.json
4 years, 1 month ago (2016-10-25 20:21:56 UTC) #12
Alexei Svitkine (slow)
https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fieldtrial_testing_config.json#newcode1714 testing/variations/fieldtrial_testing_config.json:1714: "name": "V4Hybrid", The first group is the one that ...
4 years, 1 month ago (2016-10-25 20:33:10 UTC) #13
vakh (use Gerrit instead)
Make V4Hybrid the first group so that it receives testing
4 years, 1 month ago (2016-10-25 21:56:47 UTC) #16
vakh (use Gerrit instead)
On 2016/10/25 20:33:10, Alexei Svitkine (slow) wrote: > https://codereview.chromium.org/2450963002/diff/40001/testing/variations/fieldtrial_testing_config.json > File testing/variations/fieldtrial_testing_config.json (right): > > ...
4 years, 1 month ago (2016-10-25 21:57:04 UTC) #18
rkaplow
lgtm https://codereview.chromium.org/2450963002/diff/60001/testing/variations/fieldtrial_testing_config.json File testing/variations/fieldtrial_testing_config.json (right): https://codereview.chromium.org/2450963002/diff/60001/testing/variations/fieldtrial_testing_config.json#newcode1701 testing/variations/fieldtrial_testing_config.json:1701: "name": "V4Hybrid", I actually think it makes more ...
4 years, 1 month ago (2016-10-26 02:36:20 UTC) #22
vakh (use Gerrit instead)
Rebase and enable V4Only2
3 years, 11 months ago (2017-01-26 02:37:22 UTC) #27
Alexei Svitkine (slow)
Seems like there's test failures?
3 years, 10 months ago (2017-01-27 22:04:47 UTC) #32
vakh (use Gerrit instead)
On 2017/01/27 at 22:04:47, asvitkine wrote: > Seems like there's test failures? Yes, working on ...
3 years, 10 months ago (2017-01-27 22:06:10 UTC) #33
vakh (use Gerrit instead)
3 years, 10 months ago (2017-01-27 22:06:43 UTC) #35
rkaplow
not too worried about it :) readd one of us when you are ready to ...
3 years, 10 months ago (2017-01-27 22:08:24 UTC) #37
vakh (use Gerrit instead)
rebase
3 years, 5 months ago (2017-07-11 20:38:53 UTC) #40
vakh (use Gerrit instead)
rebase
3 years, 5 months ago (2017-07-11 20:41:57 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450963002/120001
3 years, 5 months ago (2017-07-11 20:43:59 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/497266)
3 years, 5 months ago (2017-07-11 21:49:47 UTC) #51
vakh (use Gerrit instead)
Add a method to check whether SubResource filter can be checked
3 years, 5 months ago (2017-07-11 23:56:24 UTC) #56
vakh (use Gerrit instead)
rebase
3 years, 5 months ago (2017-07-12 07:35:17 UTC) #63
vakh (use Gerrit instead)
test
3 years, 5 months ago (2017-07-12 16:45:10 UTC) #73
vakh (use Gerrit instead)
Add debug information for failing tests
3 years, 5 months ago (2017-07-12 18:40:01 UTC) #78
vakh (use Gerrit instead)
rebase
3 years, 5 months ago (2017-07-12 22:27:02 UTC) #83
vakh (use Gerrit instead)
Remove erroneously added ORing of true
3 years, 5 months ago (2017-07-12 22:28:15 UTC) #86
vakh (use Gerrit instead)
rebase
3 years, 5 months ago (2017-07-13 03:40:53 UTC) #95
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450963002/280001
3 years, 5 months ago (2017-07-13 07:03:03 UTC) #102
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/427618)
3 years, 5 months ago (2017-07-13 08:14:10 UTC) #104
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450963002/280001
3 years, 5 months ago (2017-07-13 15:02:47 UTC) #106
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 15:52:44 UTC) #109
Message was sent while issue was closed.
Committed patchset #9 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/dee0b4dc2f1538b274616ab361a4...

Powered by Google App Engine
This is Rietveld 408576698