Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Issue 2450803002: Expose unprefixed RTCPeerConnection (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, tfarina, blink-reviews-w3ctests_chromium.org, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose unprefixed RTCPeerConnection Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/7dTqNBRIUrg/GfaDq9-YBAAJ BUG=658423 Committed: https://crrev.com/bd6f05dc8a968eedd449385d154741c5e3188789 Cr-Commit-Position: refs/heads/master@{#427372}

Patch Set 1 #

Patch Set 2 : Update webrtc_track_peerconnections.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -111 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/datachannel-emptystring-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/no-media-call-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/promises-call-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt View 1 chunk +73 lines, -91 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt View 1 chunk +125 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/webrtc_track_peerconnections.js View 1 3 chunks +9 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (11 generated)
foolip
4 years, 1 month ago (2016-10-25 11:27:45 UTC) #4
foolip
phoglund@, can you review webrtc_track_peerconnections.js, and skyostil@, can you rubberstamp?
4 years, 1 month ago (2016-10-25 13:07:32 UTC) #8
Sami
lgtm.
4 years, 1 month ago (2016-10-25 13:29:48 UTC) #9
hta - Chromium
lgtm The team wants to own this eventually, so we have to figure out which ...
4 years, 1 month ago (2016-10-25 13:31:12 UTC) #10
foolip
On 2016/10/25 13:31:12, hta - Chromium wrote: > lgtm > > The team wants to ...
4 years, 1 month ago (2016-10-25 14:25:40 UTC) #11
foolip
On 2016/10/25 14:25:40, foolip wrote: > On 2016/10/25 13:31:12, hta - Chromium wrote: > > ...
4 years, 1 month ago (2016-10-25 14:33:30 UTC) #12
foolip
Looks like phoglund@ is OOO, but hta@ looked at tools/perf/page_sets/webrtc_track_peerconnections.js too, so I'll go ahead ...
4 years, 1 month ago (2016-10-25 15:18:56 UTC) #15
foolip
I'll put links to the newly created issues in the IDL in https://codereview.chromium.org/2447033002
4 years, 1 month ago (2016-10-25 15:21:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2450803002/20001
4 years, 1 month ago (2016-10-25 15:21:35 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 16:06:12 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 16:14:47 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd6f05dc8a968eedd449385d154741c5e3188789
Cr-Commit-Position: refs/heads/master@{#427372}

Powered by Google App Engine
This is Rietveld 408576698