Support RTCConfiguration iceTransportPolicy

Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423
Committed: https://crrev.com/f3584c57c2d1a069f4278516e4570388d3d7322e
Cr-Commit-Position: refs/heads/master@{#427490}

[foolip, 2016-10-25 13:13:25]

foolip@chromium.org changed reviewers:
+ hta@chromium.org, mkwst@chromium.org

[foolip, 2016-10-25 13:13:25]

PTAL

[hta - Chromium, 2016-10-25 13:37:41]

Just one nit.

https://codereview.chromium.org/2447033002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2447033002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp:244: if
(iceTransportsString == "none") {
Can you do these 2 translations of icetransportPolicy to
WebRTCIceTransportPolicy just once, using either a helper function or a loop?

If future specs add more values, we don't want to allow for the possibility that
these 2 translations diverge.

[foolip, 2016-10-25 15:43:04]

https://codereview.chromium.org/2447033002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2447033002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp:244: if
(iceTransportsString == "none") {
On 2016/10/25 13:37:41, hta - Chromium wrote:
> Can you do these 2 translations of icetransportPolicy to
> WebRTCIceTransportPolicy just once, using either a helper function or a loop?
> 
> If future specs add more values, we don't want to allow for the possibility
that
> these 2 translations diverge.

Done.

[foolip, 2016-10-25 15:43:22]

Description was changed from

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

BUG=658423
==========

to

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423
==========

[foolip, 2016-10-25 15:43:46]

foolip@chromium.org changed reviewers:
+ hbos@chromium.org

[foolip, 2016-10-25 15:43:47]

hbos@, can you review content/renderer/media/rtc_peer_connection_handler.cc?

[hbos_chromium, 2016-10-25 15:48:43]

content/renderer/media/rtc_peer_connection_handler.cc lgtm

[hta - Chromium, 2016-10-25 15:59:03]

lgtm

[Mike West, 2016-10-25 16:16:46]

histograms.xml LGTM.

[foolip, 2016-10-25 16:22:49]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2016-10-25 16:23:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:19:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[foolip, 2016-10-25 19:57:22]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-25 19:57:22]

The patchset sent to the CQ was uploaded after l-g-t-m from hta@chromium.org,
mkwst@chromium.org, hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2447033002/#ps40001
(title: "update expectations")

[commit-bot: I haz the power, 2016-10-25 19:57:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:44:52]

Description was changed from

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423
==========

to

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423
==========

[commit-bot: I haz the power, 2016-10-25 21:44:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-25 21:47:03]

Description was changed from

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423
==========

to

==========
Support RTCConfiguration iceTransportPolicy

This also renames iceTransports to iceTransportPolicy internally.

Also add a few bug links to the IDL.

BUG=658423

Committed: https://crrev.com/f3584c57c2d1a069f4278516e4570388d3d7322e
Cr-Commit-Position: refs/heads/master@{#427490}
==========

[commit-bot: I haz the power, 2016-10-25 21:47:05]

Patchset 3 (id:??) landed as
https://crrev.com/f3584c57c2d1a069f4278516e4570388d3d7322e
Cr-Commit-Position: refs/heads/master@{#427490}