MD History: hide tooltip promo when drawer is swiped open

MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG=657357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28
Cr-Commit-Position: refs/heads/master@{#428089}

[Dan Beam, 2016-10-25 23:24:34]

Description was changed from

==========
MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG=657357
==========

to

==========
MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG=657357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-25 23:35:12]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 00:56:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:56:14]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-10-27 01:58:44]

ping calamity@

[calamity, 2016-10-27 02:12:41]

https://codereview.chromium.org/2450663003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2450663003/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:96: notify: true,
Does this need notify: true?

https://codereview.chromium.org/2450663003/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js (right):

https://codereview.chromium.org/2450663003/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js:38: notify: true,
Is it necessary to remove the value: false here? Can history-app set the
loadTimeData value in its ready() instead?

It's weird to require clients to set a value on showMenuPromo for the title to
render.

[Dan Beam, 2016-10-27 03:11:38]

bindings down, events up

[Dan Beam, 2016-10-27 03:11:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 03:12:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2016-10-27 03:20:31]

lgtm w/ nits.

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:111:
on-cr-toolbar-promo-close="onCrToolbarPromoClose_">
nit: The rest of the event listeners are in the js listeners object. May as well
put this one there so it doesn't get lonely.

https://codereview.chromium.org/2450663003/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js (right):

https://codereview.chromium.org/2450663003/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js:72:
this.fire('cr-menu-tap');
nit: This is a very confusing event name, especially alongside the new one.
cr-toolbar-menu-tap perhaps?

[Dan Beam, 2016-10-27 03:22:18]

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.js (right):

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/app.js:177: if (!showMenuPromo &&
oldShowMenuPromo)
damn it, this code wasn't even necessary after all

[Dan Beam, 2016-10-27 03:36:56]

Patchset #6 (id:100001) has been deleted

[Dan Beam, 2016-10-27 03:37:05]

Patchset #5 (id:80001) has been deleted

[Dan Beam, 2016-10-27 03:40:52]

Patchset #5 (id:120001) has been deleted

[Dan Beam, 2016-10-27 03:42:18]

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/app.html (right):

https://codereview.chromium.org/2450663003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/app.html:111:
on-cr-toolbar-promo-close="onCrToolbarPromoClose_">
On 2016/10/27 03:20:31, calamity wrote:
> nit: The rest of the event listeners are in the js listeners object. May as
well
> put this one there so it doesn't get lonely.

Done.

https://codereview.chromium.org/2450663003/diff/60001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js (right):

https://codereview.chromium.org/2450663003/diff/60001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js:72:
this.fire('cr-menu-tap');
On 2016/10/27 03:20:31, calamity wrote:
> nit: This is a very confusing event name, especially alongside the new one.
> cr-toolbar-menu-tap perhaps?

Done.

[Dan Beam, 2016-10-27 03:42:23]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 03:42:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-10-27 04:10:48]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-10-27 04:11:11]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-10-27 04:11:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2450663003/#ps130001
(title: "on-lonely="fixUpCode_"")

[commit-bot: I haz the power, 2016-10-27 04:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 04:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 04:27:50]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dan Beam, 2016-10-27 17:32:27]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-27 17:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:39:06]

Committed patchset #5 (id:130001)

[commit-bot: I haz the power, 2016-10-27 19:01:36]

Description was changed from

==========
MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG=657357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: hide tooltip promo when drawer is swiped open

R=calamity@chromium.org
BUG=657357
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28
Cr-Commit-Position: refs/heads/master@{#428089}
==========

[commit-bot: I haz the power, 2016-10-27 19:01:38]

Patchset 5 (id:??) landed as
https://crrev.com/e4c0fe97a41412df82df5a4b082270fef8df0f28
Cr-Commit-Position: refs/heads/master@{#428089}