Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/resources/md_history/app.js

Issue 2450663003: MD History: hide tooltip promo when drawer is swiped open (Closed)
Patch Set: on-lonely="fixUpCode_" Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/app.crisper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/app.js
diff --git a/chrome/browser/resources/md_history/app.js b/chrome/browser/resources/md_history/app.js
index 730ff7e0f8df5ed2bc22725f490c70eadd30e955..7cc406ef400055dc7b2de60a0eed8bbc1c8ca686 100644
--- a/chrome/browser/resources/md_history/app.js
+++ b/chrome/browser/resources/md_history/app.js
@@ -86,17 +86,26 @@ Polymer({
type: Boolean,
reflectToAttribute: true,
notify: true,
- }
+ },
+
+ showMenuPromo_: {
+ type: Boolean,
+ value: function() {
+ return loadTimeData.getBoolean('showMenuPromo');
+ },
+ },
},
- // TODO(calamity): Replace these event listeners with data bound properties.
listeners: {
- 'cr-menu-tap': 'onMenuTap_',
- 'history-checkbox-select': 'checkboxSelected',
- 'unselect-all': 'unselectAll',
+ 'cr-toolbar-menu-promo-close': 'onCrToolbarMenuPromoClose_',
+ 'cr-toolbar-menu-promo-shown': 'onCrToolbarMenuPromoShown_',
+ 'cr-toolbar-menu-tap': 'onCrToolbarMenuTap_',
'delete-selected': 'deleteSelected',
+ 'history-checkbox-select': 'checkboxSelected',
'history-close-drawer': 'closeDrawer_',
'history-view-changed': 'historyViewChanged_',
+ 'opened-changed': 'onOpenedChanged_',
+ 'unselect-all': 'unselectAll',
},
/** @override */
@@ -140,13 +149,32 @@ Polymer({
},
/** @private */
- onMenuTap_: function() {
+ onCrToolbarMenuPromoClose_: function() {
+ this.showMenuPromo_ = false;
+ },
+
+ /** @private */
+ onCrToolbarMenuPromoShown_: function() {
+ md_history.BrowserService.getInstance().menuPromoShown();
+ },
+
+ /** @private */
+ onCrToolbarMenuTap_: function() {
var drawer = this.$$('#drawer');
if (drawer)
drawer.toggle();
},
/**
+ * @param {!CustomEvent} e
+ * @private
+ */
+ onOpenedChanged_: function(e) {
+ if (e.detail.value)
+ this.showMenuPromo_ = false;
+ },
+
+ /**
* Listens for history-item being selected or deselected (through checkbox)
* and changes the view of the top toolbar.
* @param {{detail: {countAddition: number}}} e
« no previous file with comments | « chrome/browser/resources/md_history/app.html ('k') | chrome/browser/resources/md_history/app.crisper.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698